'Re: Review Request 119373: vimode: moving all the mode-related files into a new directory "modes".'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 119373: vimode: moving all the mode-related files into a new directory "modes".
From:       Miquel_SabatĂŠ_SolĂ  <mikisabate () gmail ! com>
Date:       2014-07-19 20:06:33
Message-ID: 20140719200633.21437.53314 () probe ! kde ! org
[Download RAW message or body]

--===============3910678394723210426==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On July 19, 2014, 7:15 p.m., Michal Humpula wrote:
> > src/vimode/modes/insertmode.h, line 37
> > <https://git.reviewboard.kde.org/r/119373/diff/1/?file=291295#file291295line37>
> > 
> > This should go to KateVi namespace too, shouldn't it?

done ;)

- Miquel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119373/#review62711
-----------------------------------------------------------

On July 19, 2014, 8:05 p.m., Miquel SabatĂŠ SolĂ  wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119373/
> -----------------------------------------------------------
> 
> (Updated July 19, 2014, 8:05 p.m.)
> 
> 
> Review request for Kate, Michal Humpula and Simon St James.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> I've created a new directory named "modes" and I've put all the files related to \
> modes in there. I've also ported all the modes inside the KateVi namespace. 
> @Michal: I know that you have the plan to get rid of the modes, but let's keep them \
> in a separate directory while this is not happening ;) 
> 
> Diffs
> -----
> 
> src/vimode/modes/normalmode.cpp PRE-CREATION 
> src/vimode/modes/replacemode.h PRE-CREATION 
> src/vimode/modes/replacemode.cpp PRE-CREATION 
> src/vimode/modes/visualmode.h PRE-CREATION 
> src/vimode/modes/visualmode.cpp PRE-CREATION 
> src/vimode/searcher.cpp 2709ddf 
> src/vimode/katevimotion.h 0cea035 
> src/vimode/katevimotion.cpp bd0a528 
> src/vimode/katevinormalmode.h 12c6dd7 
> src/vimode/katevinormalmode.cpp 1bbf1f3 
> src/vimode/katevireplacemode.h 1cd4c76 
> src/vimode/katevireplacemode.cpp cdf8765 
> src/vimode/katevivisualmode.h 6ea2d5c 
> src/vimode/katevivisualmode.cpp 82b1983 
> src/vimode/mappings.cpp c5d17e4 
> src/vimode/marks.cpp ceeb59a 
> src/vimode/modes/insertmode.h PRE-CREATION 
> src/vimode/modes/insertmode.cpp PRE-CREATION 
> src/vimode/modes/modebase.h PRE-CREATION 
> src/vimode/modes/modebase.cpp PRE-CREATION 
> src/vimode/modes/normalmode.h PRE-CREATION 
> src/vimode/kateviinputmodemanager.h 27a355d 
> src/vimode/kateviinputmodemanager.cpp 6efb86b 
> src/vimode/kateviinsertmode.h 5da6e04 
> src/vimode/kateviinsertmode.cpp 56ff9aa 
> src/vimode/katevimodebase.h b747f6b 
> src/vimode/katevimodebase.cpp 8fcd26f 
> src/vimode/katevicommand.cpp 88150c7 
> src/vimode/kateviemulatedcommandbar.cpp b67bee2 
> src/CMakeLists.txt 4394a84 
> src/inputmode/kateviinputmode.cpp ad3805b 
> src/vimode/katevicmds.cpp f009fd3 
> src/vimode/katevicommand.h 0538147 
> 
> Diff: https://git.reviewboard.kde.org/r/119373/diff/
> 
> 
> Testing
> -------
> 
> make test
> 
> 
> Thanks,
> 
> Miquel SabatĂŠ SolĂ 
> 
> 

--===============3910678394723210426==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119373/">https://git.reviewboard.kde.org/r/119373/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 19th, 2014, 7:15 p.m. UTC, <b>Michal \
Humpula</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/119373/diff/1/?file=291295#file291295line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/vimode/modes/insertmode.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">37</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">enum</span> <span class="n">BlockInsert</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
should go to KateVi namespace too, shouldn't it?</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">done ;)</p></pre> <br />

<p>- Miquel</p>

<br />
<p>On July 19th, 2014, 8:05 p.m. UTC, Miquel SabatĂŠ SolĂ  wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate, Michal Humpula and Simon St James.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated July 19, 2014, 8:05 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've created a new directory named "modes" and I've \
put all the files related to modes in there. I've also ported all the modes inside \
the KateVi namespace.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">@Michal: I know that you have the plan \
to get rid of the modes, but let's keep them in a separate directory while this is \
not happening ;)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make test</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/vimode/modes/normalmode.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/vimode/modes/replacemode.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/vimode/modes/replacemode.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/vimode/modes/visualmode.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/vimode/modes/visualmode.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/vimode/searcher.cpp <span style="color: grey">(2709ddf)</span></li>

 <li>src/vimode/katevimotion.h <span style="color: grey">(0cea035)</span></li>

 <li>src/vimode/katevimotion.cpp <span style="color: grey">(bd0a528)</span></li>

 <li>src/vimode/katevinormalmode.h <span style="color: grey">(12c6dd7)</span></li>

 <li>src/vimode/katevinormalmode.cpp <span style="color: grey">(1bbf1f3)</span></li>

 <li>src/vimode/katevireplacemode.h <span style="color: grey">(1cd4c76)</span></li>

 <li>src/vimode/katevireplacemode.cpp <span style="color: grey">(cdf8765)</span></li>

 <li>src/vimode/katevivisualmode.h <span style="color: grey">(6ea2d5c)</span></li>

 <li>src/vimode/katevivisualmode.cpp <span style="color: grey">(82b1983)</span></li>

 <li>src/vimode/mappings.cpp <span style="color: grey">(c5d17e4)</span></li>

 <li>src/vimode/marks.cpp <span style="color: grey">(ceeb59a)</span></li>

 <li>src/vimode/modes/insertmode.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/vimode/modes/insertmode.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/vimode/modes/modebase.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/vimode/modes/modebase.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/vimode/modes/normalmode.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/vimode/kateviinputmodemanager.h <span style="color: \
grey">(27a355d)</span></li>

 <li>src/vimode/kateviinputmodemanager.cpp <span style="color: \
grey">(6efb86b)</span></li>

 <li>src/vimode/kateviinsertmode.h <span style="color: grey">(5da6e04)</span></li>

 <li>src/vimode/kateviinsertmode.cpp <span style="color: grey">(56ff9aa)</span></li>

 <li>src/vimode/katevimodebase.h <span style="color: grey">(b747f6b)</span></li>

 <li>src/vimode/katevimodebase.cpp <span style="color: grey">(8fcd26f)</span></li>

 <li>src/vimode/katevicommand.cpp <span style="color: grey">(88150c7)</span></li>

 <li>src/vimode/kateviemulatedcommandbar.cpp <span style="color: \
grey">(b67bee2)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(4394a84)</span></li>

 <li>src/inputmode/kateviinputmode.cpp <span style="color: \
grey">(ad3805b)</span></li>

 <li>src/vimode/katevicmds.cpp <span style="color: grey">(f009fd3)</span></li>

 <li>src/vimode/katevicommand.h <span style="color: grey">(0538147)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119373/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3910678394723210426==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 