'Re: Review Request 119364: vimode: removed all the "using namespace KTextEditor" and similar.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 119364: vimode: removed all the "using namespace KTextEditor" and similar.
From:       Miquel_SabatĂŠ_SolĂ  <mikisabate () gmail ! com>
Date:       2014-07-19 12:09:40
Message-ID: 20140719120940.21437.2549 () probe ! kde ! org
[Download RAW message or body]

--===============5409301310581733565==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119364/
-----------------------------------------------------------

(Updated July 19, 2014, 12:09 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate, Michal Humpula and Simon St James.

Repository: ktexteditor

Description
-------

As mentioned in the review request #119359, it would be great if someone would remove \
all the "using namespace KTextEditor" and friends from the code. Well, this is what \
I've done in this patch basically.

Diffs
-----

  src/inputmode/kateviinputmode.cpp c299103 
  src/vimode/completionreplayer.cpp 585ff92 
  src/vimode/kateviemulatedcommandbar.h 5d8800b 
  src/vimode/kateviemulatedcommandbar.cpp 0f6cfea 
  src/vimode/kateviinputmodemanager.h 356c84a 
  src/vimode/kateviinputmodemanager.cpp fe0f705 
  src/vimode/kateviinsertmode.h ff221b4 
  src/vimode/kateviinsertmode.cpp 24c4d59 
  src/vimode/katevimodebase.h 9266264 
  src/vimode/katevimodebase.cpp ea6ca10 
  src/vimode/katevinormalmode.h a7fc2c1 
  src/vimode/katevinormalmode.cpp 9b3ddd6 
  src/vimode/katevireplacemode.cpp d634c96 
  src/vimode/katevivisualmode.h 68e3c21 
  src/vimode/katevivisualmode.cpp 8095caf 
  src/vimode/searcher.cpp 5fa55c0 

Diff: https://git.reviewboard.kde.org/r/119364/diff/

Testing
-------

make test

Thanks,

Miquel SabatĂŠ SolĂ 

--===============5409301310581733565==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119364/">https://git.reviewboard.kde.org/r/119364/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate, Michal Humpula and Simon St James.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated July 19, 2014, 12:09 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As mentioned in the review request #119359, it would \
be great if someone would remove all the "using namespace KTextEditor" and friends \
from the code. Well, this is what I've done in this patch basically.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make test</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/inputmode/kateviinputmode.cpp <span style="color: \
grey">(c299103)</span></li>

 <li>src/vimode/completionreplayer.cpp <span style="color: \
grey">(585ff92)</span></li>

 <li>src/vimode/kateviemulatedcommandbar.h <span style="color: \
grey">(5d8800b)</span></li>

 <li>src/vimode/kateviemulatedcommandbar.cpp <span style="color: \
grey">(0f6cfea)</span></li>

 <li>src/vimode/kateviinputmodemanager.h <span style="color: \
grey">(356c84a)</span></li>

 <li>src/vimode/kateviinputmodemanager.cpp <span style="color: \
grey">(fe0f705)</span></li>

 <li>src/vimode/kateviinsertmode.h <span style="color: grey">(ff221b4)</span></li>

 <li>src/vimode/kateviinsertmode.cpp <span style="color: grey">(24c4d59)</span></li>

 <li>src/vimode/katevimodebase.h <span style="color: grey">(9266264)</span></li>

 <li>src/vimode/katevimodebase.cpp <span style="color: grey">(ea6ca10)</span></li>

 <li>src/vimode/katevinormalmode.h <span style="color: grey">(a7fc2c1)</span></li>

 <li>src/vimode/katevinormalmode.cpp <span style="color: grey">(9b3ddd6)</span></li>

 <li>src/vimode/katevireplacemode.cpp <span style="color: grey">(d634c96)</span></li>

 <li>src/vimode/katevivisualmode.h <span style="color: grey">(68e3c21)</span></li>

 <li>src/vimode/katevivisualmode.cpp <span style="color: grey">(8095caf)</span></li>

 <li>src/vimode/searcher.cpp <span style="color: grey">(5fa55c0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119364/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5409301310581733565==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 