[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 119078: don't crash if coordinates of a cursor behind the document's end are requ
From: "Commit Hook" <null () kde ! org>
Date: 2014-07-04 10:09:27
Message-ID: 20140704100927.17149.70734 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119078/#review61595
-----------------------------------------------------------
This review has been submitted with commit b5542ab92107f7dfb6d58a78c707dcab3a50db9a \
by Dominik Haumann on behalf of Sven Brauch to branch KDE/4.13.
- Commit Hook
On July 2, 2014, 3:53 p.m., Sven Brauch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119078/
> -----------------------------------------------------------
>
> (Updated July 2, 2014, 3:53 p.m.)
>
>
> Review request for Kate and Dominik Haumann.
>
>
> Bugs: 334693
> http://bugs.kde.org/show_bug.cgi?id=334693
>
>
> Repository: kate
>
>
> Description
> -------
>
> This caused various crashes in the bracket matching animation and the
> collaborative plugin's popup animations if they affected text near the end
> of the document which was then removed. The fix applied by this commit is
> rather broad, but should prevent all similar crashes in the future
> by making the API more robust.
>
>
> Diffs
> -----
>
> tests/kateview_test.cpp a24c3bfaafb2b3707dd8d39f54659f28a2f966e9
> part/view/kateviewinternal.cpp a16f106a875010f484cc5a68441bd362c1827b95
> part/render/katelayoutcache.cpp 367fca7d763a66cd12ea3fffdead9f2abdeeee2d
>
> Diff: https://git.reviewboard.kde.org/r/119078/diff/
>
>
> Testing
> -------
>
> To reproduce the linked bug: enable bracket animation, type brackets in the last \
> line of the document, press Ctrl+K immediately afterwards -> crash. To make it \
> easier to reproduce, set the animation time to 3 seconds in code. With this fix \
> applied, the crash is gone.
>
> Thanks,
>
> Sven Brauch
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119078/">https://git.reviewboard.kde.org/r/119078/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit b5542ab92107f7dfb6d58a78c707dcab3a50db9a by Dominik Haumann on \
behalf of Sven Brauch to branch KDE/4.13.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On July 2nd, 2014, 3:53 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Dominik Haumann.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated July 2, 2014, 3:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334693">334693</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> This caused various crashes in the bracket matching animation and \
the collaborative plugin's popup animations if they affected text near the end
of the document which was then removed. The fix applied by this commit is
rather broad, but should prevent all similar crashes in the future
by making the API more robust.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To reproduce the linked bug: enable bracket animation, type brackets in \
the last line of the document, press Ctrl+K immediately afterwards -> crash. To \
make it easier to reproduce, set the animation time to 3 seconds in code. With this \
fix applied, the crash is gone.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/kateview_test.cpp <span style="color: \
grey">(a24c3bfaafb2b3707dd8d39f54659f28a2f966e9)</span></li>
<li>part/view/kateviewinternal.cpp <span style="color: \
grey">(a16f106a875010f484cc5a68441bd362c1827b95)</span></li>
<li>part/render/katelayoutcache.cpp <span style="color: \
grey">(367fca7d763a66cd12ea3fffdead9f2abdeeee2d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119078/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic