[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 119028: Added the closeViewSpace to the KTextEditor::MainWindow class.
From: "Commit Hook" <null () kde ! org>
Date: 2014-07-01 18:27:15
Message-ID: 20140701182715.22318.70045 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119028/#review61416
-----------------------------------------------------------
This review has been submitted with commit 53c2492bc4880b51017c9b4214a928dbbd89d845 \
by Miquel Sabaté to branch master.
- Commit Hook
On July 1, 2014, 6:24 p.m., Miquel Sabaté Solà wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119028/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 6:24 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> This is a method that I needed in order to implement the "close" command in \
> vi-mode. The close command in vim closes the current "window". This concept of \
> "window" is basically a splitted view. That's why other commands in vi-mode such as \
> "split" and "vsplit" have been implemented by just splitting the current view. \
> However, it's not possible to close a splitted view. The only thing that is close \
> is the "closeView" method, but it's not really what we want, since calling this \
> function will result in the image that I have uploaded. Therefore, before this \
> patch, the KatePart allowed the creation of splitted views, but it didn't allow the \
> deletion of splitted views (and that's inconsistent imho).
> With this function, now we can close splitted views as expected. In Kate \
> (frameworks branch), the implementation of this function is trivial because the \
> KateMainWindow class has access to the KateViewManager class (through \
> m_viewManager).
>
> Diffs
> -----
>
> src/include/ktexteditor/mainwindow.h fda80a2
> src/utils/mainwindow.cpp 1231f9a
>
> Diff: https://git.reviewboard.kde.org/r/119028/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
>
> File Attachments
> ----------------
>
> closeView in action
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/30/fa7ce216-cc21-4647-8f72-f663374623c4__kate.png
>
>
> Thanks,
>
> Miquel SabatĂ© SolĂ
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119028/">https://git.reviewboard.kde.org/r/119028/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 53c2492bc4880b51017c9b4214a928dbbd89d845 by Miquel Sabaté to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On July 1st, 2014, 6:24 p.m. UTC, Miquel Sabaté Solà wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Miquel Sabaté Solà .</div>
<p style="color: grey;"><i>Updated July 1, 2014, 6:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a method that I needed in order to implement the \
"close" command in vi-mode. The close command in vim closes the current \
"window". This concept of "window" is basically a splitted view. \
That's why other commands in vi-mode such as "split" and \
"vsplit" have been implemented by just splitting the current view. However, \
it's not possible to close a splitted view. The only thing that is close is the \
"closeView" method, but it's not really what we want, since calling \
this function will result in the image that I have uploaded. Therefore, before this \
patch, the KatePart allowed the creation of splitted views, but it didn't allow \
the deletion of splitted views (and that's inconsistent imho).
With this function, now we can close splitted views as expected. In Kate (frameworks \
branch), the implementation of this function is trivial because the KateMainWindow \
class has access to the KateViewManager class (through m_viewManager).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual testing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/include/ktexteditor/mainwindow.h <span style="color: \
grey">(fda80a2)</span></li>
<li>src/utils/mainwindow.cpp <span style="color: grey">(1231f9a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119028/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/30/fa7ce216-cc21-4647-8f72-f663374623c4__kate.png">closeView \
in action</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic