[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 118312: Do not reset the model without need
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2014-06-30 18:17:07
Message-ID: 20140630181707.17520.20419 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118312/
-----------------------------------------------------------
(Updated June 30, 2014, 6:17 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate and Michal Humpula.
Bugs: 332990
http://bugs.kde.org/show_bug.cgi?id=332990
Repository: kate
Description
-------
From reading the code i see no need to reset the model, the only think that i see the \
reset do is cause the view to "reset" too and the state of open/closed roots in the \
tree gets broken.
Diffs
-----
kate/filetree/katefiletreemodel.cpp 62e39e5
Diff: https://git.reviewboard.kde.org/r/118312/diff/
Testing
-------
Used it for a few minutes and everything worked fine. Reading the code don't see why \
it shouldn't. I'll it use it a bit more for a few more days.
Thanks,
Albert Astals Cid
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118312/">https://git.reviewboard.kde.org/r/118312/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Michal Humpula.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated June 30, 2014, 6:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332990">332990</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">From reading the code i see no need to reset the model, the only think \
that i see the reset do is cause the view to "reset" too and the state of \
open/closed roots in the tree gets broken.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used it for a few minutes and everything worked fine. Reading the code \
don't see why it shouldn't. I'll it use it a bit more for a few more \
days.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/filetree/katefiletreemodel.cpp <span style="color: \
grey">(62e39e5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118312/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic