[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 118992: vi-mode: restore only user marks to bookmarks
From: Miquel_Sabaté_Solà <mikisabate () gmail ! com>
Date: 2014-06-28 15:17:43
Message-ID: 20140628151743.18724.22356 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 28, 2014, 3:16 p.m., Miquel Sabaté Solà wrote:
> > part/vimode/kateviinputmodemanager.cpp, line 849
> > <https://git.reviewboard.kde.org/r/118992/diff/1/?file=285095#file285095line849>
> >
> > QLatin1Char('a') >= markerChar. Anyways, wouldn't it just work with \
> > markerChar.isLetter() ?
Ah, nevermind about the QLatin1Char('a') >= markerChar, you're right :P But what \
about isLetter?
- Miquel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118992/#review61135
-----------------------------------------------------------
On June 28, 2014, 2:13 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118992/
> -----------------------------------------------------------
>
> (Updated June 28, 2014, 2:13 p.m.)
>
>
> Review request for Kate and Miquel Sabaté Solà .
>
>
> Repository: kate
>
>
> Description
> -------
>
> This was bugging me for quite some time... files spoiled with too much bookmarks. \
> Turns out that vi-mode restores every single mark to bookmark when opening session. \
> So this patch adds a filter for regular characters only.
> If agread, for ktexteditor I would come up with cleaner version.
>
>
> Diffs
> -----
>
> part/vimode/kateviinputmodemanager.cpp 79229bb
>
> Diff: https://git.reviewboard.kde.org/r/118992/diff/
>
>
> Testing
> -------
>
> make test + manual testing
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118992/">https://git.reviewboard.kde.org/r/118992/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 28th, 2014, 3:16 p.m. UTC, <b>Miquel \
Sabaté Solà </b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118992/diff/1/?file=285095#file285095line849" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/vimode/kateviinputmodemanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KateViInputModeManager::syncViMarksAndBookmarks() {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">849</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">QLatin1Char</span><span \
class="p">(</span><span class="sc">'a'</span><span class="p">)</span> <span \
class="o"><=</span> <span class="n">markerChar</span> <span \
class="o">&&</span> <span class="n">markerChar</span> <span \
class="o"><=</span> <span class="n">QLatin1Char</span><span \
class="p">(</span><span class="sc">'z'</span><span class="p">))</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QLatin1Char('a') \
>= markerChar. Anyways, wouldn't it just work with markerChar.isLetter() \
?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, \
nevermind about the QLatin1Char('a') >= markerChar, you're right :P \
But what about isLetter?</pre> <br />
<p>- Miquel</p>
<br />
<p>On June 28th, 2014, 2:13 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Miquel Sabaté Solà .</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated June 28, 2014, 2:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This was bugging me for quite some time... files spoiled with too much \
bookmarks. Turns out that vi-mode restores every single mark to bookmark when opening \
session. So this patch adds a filter for regular characters only.
If agread, for ktexteditor I would come up with cleaner version.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">make test + manual testing</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/vimode/kateviinputmodemanager.cpp <span style="color: \
grey">(79229bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118992/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic