'Re: Review Request 118748: Add option to fold comment block at the start of a file.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 118748: Add option to fold comment block at the start of a file.
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2014-06-26 10:51:50
Message-ID: 20140626105150.26151.80274 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118748/
-----------------------------------------------------------

(Updated June 26, 2014, 10:51 a.m.)

Review request for Kate.

Changes
-------

addressed dominiks comments

Repository: kate

Description
-------

Add option to fold comment block at the start of a file.

This is nice to save screen real-estate by hiding license headers.
A setting for this is added, which is disabled by default.

Diffs (updated)
-----

  part/dialogs/katedialogs.cpp 868bff5 
  part/dialogs/textareaappearanceconfigwidget.ui 81cd098 
  part/utils/kateconfig.h c0407f7 
  part/utils/kateconfig.cpp 988610f 
  part/view/kateview.cpp 5ede57e 

Diff: https://git.reviewboard.kde.org/r/118748/diff/

Testing
-------

Manual tests, seems to work nicely.

Thanks,

Milian Wolff

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118748/">https://git.reviewboard.kde.org/r/118748/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Milian Wolff.</div>

<p style="color: grey;"><i>Updated June 26, 2014, 10:51 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">addressed dominiks comments</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add option to fold comment block at the start of a file.

This is nice to save screen real-estate by hiding license headers.
A setting for this is added, which is disabled by default.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual tests, seems to work nicely.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>part/dialogs/katedialogs.cpp <span style="color: grey">(868bff5)</span></li>

 <li>part/dialogs/textareaappearanceconfigwidget.ui <span style="color: \
grey">(81cd098)</span></li>

 <li>part/utils/kateconfig.h <span style="color: grey">(c0407f7)</span></li>

 <li>part/utils/kateconfig.cpp <span style="color: grey">(988610f)</span></li>

 <li>part/view/kateview.cpp <span style="color: grey">(5ede57e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118748/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 