'Re: Review Request 117427: [Markdown]: Fix highlighting of hard-wrapped block contexts'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 117427: [Markdown]: Fix highlighting of hard-wrapped block contexts
From:       "Dominik Haumann" <dhaumann () kde ! org>
Date:       2014-06-10 8:31:56
Message-ID: 20140610083156.17951.36534 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On June 8, 2014, 12:16 p.m., Christoph Rüßler wrote:
> > Ship It!

Can you commit this yourself, or should we do it?

- Dominik

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117427/#review59559
-----------------------------------------------------------

On April 7, 2014, 8:44 p.m., Christoph Rüßler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117427/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 8:44 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Bugs: 332636
> http://bugs.kde.org/show_bug.cgi?id=332636
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> This patch fixes hard-wrapped block contexts (blockquotes, numbered and bullet \
> lists) in Markdown not getting properly highlighted: now the whole paragraph gets \
> highlighted instead of just the first line. Side effect: with this patch an empty \
> line is needed to change the highlighting context which is in accordance with \
> http://daringfireball.net/projects/markdown/syntax: "A paragraph is simply one or \
> more consecutive lines of text, separated by one or more blank lines." 
> 
> Diffs
> -----
> 
> part/syntax/data/markdown.xml 36aff97f4ce05e0c9065187dce5b984d9cfc2757 
> 
> Diff: https://git.reviewboard.kde.org/r/117427/diff/
> 
> 
> Testing
> -------
> 
> Several hours of usage revealed no errors so far.
> 
> 
> Thanks,
> 
> Christoph Rüßler
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117427/">https://git.reviewboard.kde.org/r/117427/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 8th, 2014, 12:16 p.m. UTC, <b>Christoph \
Rüßler</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you commit this \
yourself, or should we do it?</pre> <br />

<p>- Dominik</p>

<br />
<p>On April 7th, 2014, 8:44 p.m. UTC, Christoph Rüßler wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Christoph Rüßler.</div>

<p style="color: grey;"><i>Updated April 7, 2014, 8:44 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=332636">332636</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes hard-wrapped block contexts (blockquotes, numbered and \
bullet lists) in Markdown not getting properly highlighted: now the whole paragraph \
gets highlighted instead of just the first line. Side effect: with this patch an \
empty line is needed to change the highlighting context which is in accordance with \
http://daringfireball.net/projects/markdown/syntax: "A paragraph is simply one or \
more consecutive lines of text, separated by one or more blank lines."</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Several hours of usage revealed no errors so far.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/syntax/data/markdown.xml <span style="color: \
grey">(36aff97f4ce05e0c9065187dce5b984d9cfc2757)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117427/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 