--===============8108083549154041520== Content-Type: multipart/alternative; boundary="===============2029491607364635778==" --===============2029491607364635778== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118616/ ----------------------------------------------------------- Review request for Kate. Repository: kate Description ------- This patch adds an action to the Kate component that allows the reloading of the syntax highlighting files. Since I am not very familiar with the codebase I might have overlooked something, especially related to memory management. Please let me know if I can improve the patch! Diffs ----- part/syntax/katehighlight.h c2d4397e45d0dcba8fa5e822710cae8ea1643aee part/syntax/katehighlight.cpp 7d956e53b0aee2a7fb5a636de18858a736c65ae4 part/view/kateview.h 6a522dabe4b1c9c96a8157abfb8716faba049234 part/view/kateview.cpp 5ede57e9af184c1f16098dadccec34211497d15a Diff: https://git.reviewboard.kde.org/r/118616/diff/ Testing ------- I tested that the reloading works by editing the Markdown syntax highlighting file. After applying a change and reloading the file using the previously set shortcut, the highlighting changed correctly. Thanks, Christoph Rüßler --===============2029491607364635778== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118616/

Review request for Kate.
By Christoph Rüßler.
Repository: kate

Description 

This patch adds an action to the Kate component that allows the reloading of the syntax highlighting files.

Since I am not very familiar with the codebase I might have overlooked something, especially related to memory management.

Please let me know if I can improve the patch!

Testing 

I tested that the reloading works by editing the Markdown syntax highlighting file. After applying a change and reloading the file using the previously set shortcut, the highlighting changed correctly.

Diffs

  • part/syntax/katehighlight.h (c2d4397e45d0dcba8fa5e822710cae8ea1643aee)
  • part/syntax/katehighlight.cpp (7d956e53b0aee2a7fb5a636de18858a736c65ae4)
  • part/view/kateview.h (6a522dabe4b1c9c96a8157abfb8716faba049234)
  • part/view/kateview.cpp (5ede57e9af184c1f16098dadccec34211497d15a)

View Diff
--===============2029491607364635778==-- --===============8108083549154041520== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============8108083549154041520==--