[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 118312: Do not reset the model without need
From: "Sven Brauch" <svenbrauch () googlemail ! com>
Date: 2014-05-25 17:12:54
Message-ID: 20140525171254.15632.39003 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 25, 2014, 10:30 a.m., Michal Humpula wrote:
> > Albert, please try to open session with several hundred documents with and \
> > without your patch. I think this was done, because adding nodes to models was \
> > generating all sorts of events and it slowed down the load time, even though the \
> > only events that matters are the last ones.
>
> Albert Astals Cid wrote:
> Well, the ui is broken, is that acceptable for a ¿corner case? speed win?
>
> Michal Humpula wrote:
> For one person "corner case" is for another "common thing". But I get your point.
>
> Isn't there another way to tell the views: "stop redrawing until I finish this big \
> transaction"? The spead up is not small, it goes like ten times, if I remember \
> correctly.
There's this: http://qt-project.org/doc/qt-4.8/qwidget.html#updatesEnabled-prop
- Sven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118312/#review58415
-----------------------------------------------------------
On May 25, 2014, 9:57 a.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118312/
> -----------------------------------------------------------
>
> (Updated May 25, 2014, 9:57 a.m.)
>
>
> Review request for Kate and Michal Humpula.
>
>
> Bugs: 332990
> http://bugs.kde.org/show_bug.cgi?id=332990
>
>
> Repository: kate
>
>
> Description
> -------
>
> From reading the code i see no need to reset the model, the only think that i see \
> the reset do is cause the view to "reset" too and the state of open/closed roots in \
> the tree gets broken.
>
> Diffs
> -----
>
> kate/filetree/katefiletreemodel.cpp 62e39e5
>
> Diff: https://git.reviewboard.kde.org/r/118312/diff/
>
>
> Testing
> -------
>
> Used it for a few minutes and everything worked fine. Reading the code don't see \
> why it shouldn't. I'll it use it a bit more for a few more days.
>
> Thanks,
>
> Albert Astals Cid
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118312/">https://git.reviewboard.kde.org/r/118312/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 25th, 2014, 10:30 a.m. UTC, <b>Michal \
Humpula</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Albert, please try to open session with several hundred documents with \
and without your patch. I think this was done, because adding nodes to models was \
generating all sorts of events and it slowed down the load time, even though the only \
events that matters are the last ones.</pre> </blockquote>
<p>On May 25th, 2014, 3:26 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the ui is broken, \
is that acceptable for a ¿corner case? speed win? </pre> </blockquote>
<p>On May 25th, 2014, 5:03 p.m. UTC, <b>Michal Humpula</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For one person \
"corner case" is for another "common thing". But I get your \
point.
Isn't there another way to tell the views: "stop redrawing until I finish \
this big transaction"? The spead up is not small, it goes like ten times, if I \
remember correctly.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's this: \
http://qt-project.org/doc/qt-4.8/qwidget.html#updatesEnabled-prop</pre> <br />
<p>- Sven</p>
<br />
<p>On May 25th, 2014, 9:57 a.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Michal Humpula.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated May 25, 2014, 9:57 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332990">332990</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">From reading the code i see no need to reset the model, the only think \
that i see the reset do is cause the view to "reset" too and the state of \
open/closed roots in the tree gets broken.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used it for a few minutes and everything worked fine. Reading the code \
don't see why it shouldn't. I'll it use it a bit more for a few more \
days.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/filetree/katefiletreemodel.cpp <span style="color: \
grey">(62e39e5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118312/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic