--===============7504952799740058575== Content-Type: multipart/alternative; boundary="===============9129075430481648184==" --===============9129075430481648184== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117427/#review56614 ----------------------------------------------------------- Ship it! Ship It! - Christoph Cullmann On April 7, 2014, 8:44 p.m., Christoph Rüßler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117427/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 8:44 p.m.) > > > Review request for Kate. > > > Bugs: 332636 > http://bugs.kde.org/show_bug.cgi?id=332636 > > > Repository: kate > > > Description > ------- > > This patch fixes hard-wrapped block contexts (blockquotes, numbered and bullet lists) in Markdown not getting properly highlighted: now the whole paragraph gets highlighted instead of just the first line. > Side effect: with this patch an empty line is needed to change the highlighting context which is in accordance with http://daringfireball.net/projects/markdown/syntax: “A paragraph is simply one or more consecutive lines of text, separated by one or more blank lines.” > > > Diffs > ----- > > part/syntax/data/markdown.xml 36aff97f4ce05e0c9065187dce5b984d9cfc2757 > > Diff: https://git.reviewboard.kde.org/r/117427/diff/ > > > Testing > ------- > > Several hours of usage revealed no errors so far. > > > Thanks, > > Christoph Rüßler > > --===============9129075430481648184== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117427/

Ship it!

Ship It!

- Christoph Cullmann

On April 7th, 2014, 8:44 p.m. UTC, Christoph Rüßler wrote:

Review request for Kate.

By Christoph Rüßler.

Updated April 7, 2014, 8:44 p.m.

Bugs: 332636

Repository: kate

Description

This patch fixes hard-wrapped block contexts (blockquotes, numbered and bullet lists) in Markdown not getting properly highlighted: now the whole paragraph gets highlighted instead of just the first line.
Side effect: with this patch an empty line is needed to change the highlighting context which is in accordance with http://daringfireball.net/projects/markdown/syntax: “A paragraph is simply one or more consecutive lines of text, separated by one or more blank lines.”

Testing

Several hours of usage revealed no errors so far.

Diffs

part/syntax/data/markdown.xml (36aff97f4ce05e0c9065187dce5b984d9cfc2757)

View Diff

--===============9129075430481648184==-- --===============7504952799740058575== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============7504952799740058575==--