'Re: Review Request 117747: vimode: fixed the cursor for the "ap" text object when the next line is e'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 117747: vimode: fixed the cursor for the "ap" text object when the next line is e
From:       "Commit Hook" <null () kde ! org>
Date:       2014-04-24 17:26:16
Message-ID: 20140424172616.8845.41026 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117747/#review56401
-----------------------------------------------------------

This review has been submitted with commit b0fd8dc894387971416ade7450ab6582a6e50191 \
by Miquel SabatĂŠ to branch KDE/4.13.

- Commit Hook

On April 24, 2014, 5:15 p.m., Miquel SabatĂŠ SolĂ  wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117747/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 5:15 p.m.)
> 
> 
> Review request for Kate, Michal Humpula and Simon St James.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Before this patch, if you do something like "vap" in the text "Hello.\n", the \
> cursor will be placed in the next line but in a column that is out-of-range. This \
> column is basically the last column of the line before the empty line. Therefore, \
> in this case we should set c.endColumn to 0. The sentence object seems to work fine \
> for this same example. Moreover, I've also removed the updateCursor call in the \
> case that we don't have to do nothing (it's pointless...). 
> 
> Diffs
> -----
> 
> autotests/src/vimode/modes.cpp e66309a 
> src/vimode/katevinormalmode.cpp aec00ec 
> 
> Diff: https://git.reviewboard.kde.org/r/117747/diff/
> 
> 
> Testing
> -------
> 
> All tests are passing. I've added a test for this.
> 
> 
> Thanks,
> 
> Miquel SabatĂŠ SolĂ 
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117747/">https://git.reviewboard.kde.org/r/117747/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit b0fd8dc894387971416ade7450ab6582a6e50191 by Miquel SabatĂŠ to \
branch KDE/4.13.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On April 24th, 2014, 5:15 p.m. UTC, Miquel SabatĂŠ SolĂ  wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate, Michal Humpula and Simon St James.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated April 24, 2014, 5:15 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Before this patch, if you do something like &quot;vap&quot; in the text \
&quot;Hello.\n&quot;, the cursor will be placed in the next line but in a column that \
is out-of-range. This column is basically the last column of the line before the \
empty line. Therefore, in this case we should set c.endColumn to 0. The sentence \
object seems to work fine for this same example. Moreover, I&#39;ve also removed the \
updateCursor call in the case that we don&#39;t have to do nothing (it&#39;s \
pointless...).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests are passing. I&#39;ve added a test for this.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/src/vimode/modes.cpp <span style="color: grey">(e66309a)</span></li>

 <li>src/vimode/katevinormalmode.cpp <span style="color: grey">(aec00ec)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117747/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 