[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 117747: vimode: fixed the cursor for the "ap" text object when the next line is e
From: "Michal Humpula" <michal.humpula () hudrydum ! cz>
Date: 2014-04-24 16:18:04
Message-ID: 20140424161804.8845.86909 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117747/#review56394
-----------------------------------------------------------
nice bug:)
autotests/src/vimode/modes.cpp
<https://git.reviewboard.kde.org/r/117747/#comment39392>
out of curiosity, this can be tested by
DoTest("Hello.\n", "vap\\esciX", "Hello.\nX");
too, cannot be?
- Michal Humpula
On April 24, 2014, 2:52 p.m., Miquel Sabaté Solà wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117747/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 2:52 p.m.)
>
>
> Review request for Kate, Michal Humpula and Simon St James.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Before this patch, if you do something like "vap" in the text "Hello.\n", the \
> cursor will be placed in the next line but in a column that is out-of-range. This \
> column is basically the last column of the line before the empty line. Therefore, \
> in this case we should set c.endColumn to 0. The sentence object seems to work fine \
> for this same example. Moreover, I've also removed the updateCursor call in the \
> case that we don't have to do nothing (it's pointless...).
>
> Diffs
> -----
>
> autotests/src/vimode/modes.cpp e66309a
> src/vimode/katevinormalmode.cpp aec00ec
>
> Diff: https://git.reviewboard.kde.org/r/117747/diff/
>
>
> Testing
> -------
>
> All tests are passing. I've added a test for this.
>
>
> Thanks,
>
> Miquel SabatĂ© SolĂ
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117747/">https://git.reviewboard.kde.org/r/117747/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nice bug:)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117747/diff/1/?file=268087#file268087line1134" \
style="color: black; font-weight: bold; text-decoration: \
underline;">autotests/src/vimode/modes.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ModesTest::VisualMotionsTests()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1134</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QCOMPARE</span><span class="p">(</span><span \
class="n">kate_view</span><span class="o">-></span><span \
class="n">cursorPosition</span><span class="p">(),</span> <span \
class="n">Cursor</span><span class="p">(</span><span class="mi">1</span><span \
class="p">,</span> <span class="mi">0</span><span class="p">));</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">out of \
curiosity, this can be tested by
DoTest("Hello.\n", "vap\\esciX", "Hello.\nX");
too, cannot be?</pre>
</div>
<br />
<p>- Michal Humpula</p>
<br />
<p>On April 24th, 2014, 2:52 p.m. UTC, Miquel Sabaté Solà wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate, Michal Humpula and Simon St James.</div>
<div>By Miquel Sabaté Solà .</div>
<p style="color: grey;"><i>Updated April 24, 2014, 2:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Before this patch, if you do something like "vap" in the text \
"Hello.\n", the cursor will be placed in the next line but in a column that \
is out-of-range. This column is basically the last column of the line before the \
empty line. Therefore, in this case we should set c.endColumn to 0. The sentence \
object seems to work fine for this same example. Moreover, I've also removed the \
updateCursor call in the case that we don't have to do nothing (it's \
pointless...).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests are passing. I've added a test for this.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/src/vimode/modes.cpp <span style="color: grey">(e66309a)</span></li>
<li>src/vimode/katevinormalmode.cpp <span style="color: grey">(aec00ec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117747/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic