'Re: Review Request 117678: a fix for bug 332426'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 117678: a fix for bug 332426
From:       "Alex Turbov" <i.zaufi () gmail ! com>
Date:       2014-04-24 8:38:27
Message-ID: 20140424083827.8845.91768 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117678/
-----------------------------------------------------------

(Updated April 24, 2014, 8:38 a.m.)

Review request for Kate.

Repository: kate

Description
-------

Add "style" attribute to C++ syntax files, so indenter can require a particular \
syntax to be active, otherwise it will be disabled.

Allow multiple values of 'required-syntax-style' property (renamed to \
'required-syntax-styles') of indenter because (formally) cppstyle.js can be used (and \
actually is) w/ more than one syntax.

See also: https://bugs.kde.org/show_bug.cgi?id=332426

Diffs (updated)
-----

  part/script/data/indentation/cmake.js 80bd5ca98d22da6e8fe6523aa7c02dd5d67c8e6f 
  part/script/data/indentation/cppstyle.js ff5ede15d917df7ce7945bc63533410a21518742 
  part/script/data/indentation/lilypond.js 5654ec760629295312af10c6a9ae9a40985b7c14 
  part/script/data/indentation/ruby.js 90c714810f52f90127804a54db4900dfc8e6189a 
  part/script/kateindentscript.h b0ede0ddce22538bc1e0112d4513046b6bdbb6a9 
  part/script/katescriptmanager.cpp 639f7e58156d390f8f5c7742c5da2005f1b3c806 
  part/syntax/data/cpp.xml d8a5764d7691eccd6de5846f95345c4690676f42 
  part/syntax/data/isocpp.xml 2578c033696de86d14e1f123134f485a3012b4c0 
  part/utils/kateautoindent.h 214e8f828b004cf1d74fdef9f3041d30caca6e9d 
  part/utils/kateautoindent.cpp 99b6ae9063d5242899f04c27301288e1e9b5559e 

Diff: https://git.reviewboard.kde.org/r/117678/diff/

Testing
-------

Thanks,

Alex Turbov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117678/">https://git.reviewboard.kde.org/r/117678/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Alex Turbov.</div>

<p style="color: grey;"><i>Updated April 24, 2014, 8:38 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add &quot;style&quot; attribute to C++ syntax files, so indenter can \
require a particular syntax to be active, otherwise it will be disabled.

Allow multiple values of &#39;required-syntax-style&#39; property (renamed to \
&#39;required-syntax-styles&#39;) of indenter because (formally) cppstyle.js can be \
used (and actually is) w/ more than one syntax.

See also: https://bugs.kde.org/show_bug.cgi?id=332426</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>part/script/data/indentation/cmake.js <span style="color: \
grey">(80bd5ca98d22da6e8fe6523aa7c02dd5d67c8e6f)</span></li>

 <li>part/script/data/indentation/cppstyle.js <span style="color: \
grey">(ff5ede15d917df7ce7945bc63533410a21518742)</span></li>

 <li>part/script/data/indentation/lilypond.js <span style="color: \
grey">(5654ec760629295312af10c6a9ae9a40985b7c14)</span></li>

 <li>part/script/data/indentation/ruby.js <span style="color: \
grey">(90c714810f52f90127804a54db4900dfc8e6189a)</span></li>

 <li>part/script/kateindentscript.h <span style="color: \
grey">(b0ede0ddce22538bc1e0112d4513046b6bdbb6a9)</span></li>

 <li>part/script/katescriptmanager.cpp <span style="color: \
grey">(639f7e58156d390f8f5c7742c5da2005f1b3c806)</span></li>

 <li>part/syntax/data/cpp.xml <span style="color: \
grey">(d8a5764d7691eccd6de5846f95345c4690676f42)</span></li>

 <li>part/syntax/data/isocpp.xml <span style="color: \
grey">(2578c033696de86d14e1f123134f485a3012b4c0)</span></li>

 <li>part/utils/kateautoindent.h <span style="color: \
grey">(214e8f828b004cf1d74fdef9f3041d30caca6e9d)</span></li>

 <li>part/utils/kateautoindent.cpp <span style="color: \
grey">(99b6ae9063d5242899f04c27301288e1e9b5559e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117678/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 