[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 117678: a fix for bug 332426
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2014-04-23 7:29:57
Message-ID: 20140423072957.6413.16521 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 22, 2014, 9:19 p.m., Milian Wolff wrote:
> > part/script/katescriptmanager.cpp, line 197
> > <https://git.reviewboard.kde.org/r/117678/diff/1/?file=267475#file267475line197>
> >
> > please stay backwards compatible and still read the required-syntax-style value \
> > if nothing is given in the plural form (also below)
>
> Alex Turbov wrote:
> I've checked that only few indenters have that property set and fix them all... not \
> sure is that backward compatibility is really needed? can you provide a real life \
> use case?
> Alex Turbov wrote:
> i.e. I mean that it seems nobody 'cept kate devs write a "third party" indenters...
I'm in favor of Milian's argument of staying backwards compatible. My suggestion is \
*for KDE 4.x* to fall back to "required-syntax-style" in case the plural form does \
not exist.
For KF5, I'd drop this fallback solution and just go with "required-syntax-styles".
Btw, thanks for working on this!
- Dominik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117678/#review56221
-----------------------------------------------------------
On April 22, 2014, 10:55 a.m., Alex Turbov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117678/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 10:55 a.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Add "style" attribute to C++ syntax files, so indenter can require a particular \
> syntax to be active, otherwise it will be disabled.
> Allow multiple values of 'required-syntax-style' property (renamed to \
> 'required-syntax-styles') of indenter because (formally) cppstyle.js can be used \
> (and actually is) w/ more than one syntax.
> See also: https://bugs.kde.org/show_bug.cgi?id=332426
>
>
> Diffs
> -----
>
> part/script/data/indentation/cmake.js 80bd5ca98d22da6e8fe6523aa7c02dd5d67c8e6f
> part/script/data/indentation/cppstyle.js ff5ede15d917df7ce7945bc63533410a21518742
> part/script/data/indentation/lilypond.js 5654ec760629295312af10c6a9ae9a40985b7c14
> part/script/data/indentation/ruby.js 90c714810f52f90127804a54db4900dfc8e6189a
> part/script/kateindentscript.h b0ede0ddce22538bc1e0112d4513046b6bdbb6a9
> part/script/katescriptmanager.cpp 639f7e58156d390f8f5c7742c5da2005f1b3c806
> part/syntax/data/cpp.xml d8a5764d7691eccd6de5846f95345c4690676f42
> part/syntax/data/isocpp.xml 2578c033696de86d14e1f123134f485a3012b4c0
> part/utils/kateautoindent.h 214e8f828b004cf1d74fdef9f3041d30caca6e9d
> part/utils/kateautoindent.cpp 99b6ae9063d5242899f04c27301288e1e9b5559e
>
> Diff: https://git.reviewboard.kde.org/r/117678/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Turbov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117678/">https://git.reviewboard.kde.org/r/117678/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 22nd, 2014, 9:19 p.m. UTC, <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117678/diff/1/?file=267475#file267475line197" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/script/katescriptmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KateScriptManager::collect(bool force)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">197</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">indentHeader</span></span><span class="p"><span \
class="hl">.</span></span><span class="n"><span \
class="hl">setRequiredStyle</span></span><span class="p"><span \
class="hl">(</span></span><span class="n">pairs</span><span class="p">.</span><span \
class="n">take</span><span class="p">(</span><span \
class="s">"required-syntax-style<span class="hl">"</span></span><span \
class="p"><span class="hl">))</span>;</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">197</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">QString</span></span><span class="hl"> </span><span \
class="n"><span class="hl">valuesStr</span></span><span class="hl"> </span><span \
class="o"><span class="hl">=</span></span><span class="hl"> </span><span \
class="n">pairs</span><span class="p">.</span><span class="n">take</span><span \
class="p">(</span><span class="s">"required-syntax-style<span \
class="hl">s"</span></span><span class="p"><span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please stay backwards \
compatible and still read the required-syntax-style value if nothing is given in the \
plural form (also below)</pre> </blockquote>
<p>On April 22nd, 2014, 9:23 p.m. UTC, <b>Alex Turbov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've checked that \
only few indenters have that property set and fix them all... not sure is that \
backward compatibility is really needed? can you provide a real life use case?</pre>
</blockquote>
<p>On April 22nd, 2014, 9:24 p.m. UTC, <b>Alex Turbov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i.e. I mean that it \
seems nobody 'cept kate devs write a "third party" indenters...</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm in \
favor of Milian's argument of staying backwards compatible. My suggestion is *for \
KDE 4.x* to fall back to "required-syntax-style" in case the plural form \
does not exist.
For KF5, I'd drop this fallback solution and just go with \
"required-syntax-styles". Btw, thanks for working on this!</pre>
<br />
<p>- Dominik</p>
<br />
<p>On April 22nd, 2014, 10:55 a.m. UTC, Alex Turbov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Alex Turbov.</div>
<p style="color: grey;"><i>Updated April 22, 2014, 10:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add "style" attribute to C++ syntax files, so indenter can \
require a particular syntax to be active, otherwise it will be disabled.
Allow multiple values of 'required-syntax-style' property (renamed to \
'required-syntax-styles') of indenter because (formally) cppstyle.js can be \
used (and actually is) w/ more than one syntax.
See also: https://bugs.kde.org/show_bug.cgi?id=332426</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/script/data/indentation/cmake.js <span style="color: \
grey">(80bd5ca98d22da6e8fe6523aa7c02dd5d67c8e6f)</span></li>
<li>part/script/data/indentation/cppstyle.js <span style="color: \
grey">(ff5ede15d917df7ce7945bc63533410a21518742)</span></li>
<li>part/script/data/indentation/lilypond.js <span style="color: \
grey">(5654ec760629295312af10c6a9ae9a40985b7c14)</span></li>
<li>part/script/data/indentation/ruby.js <span style="color: \
grey">(90c714810f52f90127804a54db4900dfc8e6189a)</span></li>
<li>part/script/kateindentscript.h <span style="color: \
grey">(b0ede0ddce22538bc1e0112d4513046b6bdbb6a9)</span></li>
<li>part/script/katescriptmanager.cpp <span style="color: \
grey">(639f7e58156d390f8f5c7742c5da2005f1b3c806)</span></li>
<li>part/syntax/data/cpp.xml <span style="color: \
grey">(d8a5764d7691eccd6de5846f95345c4690676f42)</span></li>
<li>part/syntax/data/isocpp.xml <span style="color: \
grey">(2578c033696de86d14e1f123134f485a3012b4c0)</span></li>
<li>part/utils/kateautoindent.h <span style="color: \
grey">(214e8f828b004cf1d74fdef9f3041d30caca6e9d)</span></li>
<li>part/utils/kateautoindent.cpp <span style="color: \
grey">(99b6ae9063d5242899f04c27301288e1e9b5559e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117678/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic