'Re: Review Request 117634: vimode: implemented the ctrl-w and the ctrl-u commands in replace mode.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 117634: vimode: implemented the ctrl-w and the ctrl-u commands in replace mode.
From:       "Commit Hook" <null () kde ! org>
Date:       2014-04-18 19:00:44
Message-ID: 20140418190044.11639.82168 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117634/#review56038
-----------------------------------------------------------

This review has been submitted with commit 660ae669390a4bd7a4111f0023c82e70b55fa49e \
by Miquel SabatĂŠ to branch master.

- Commit Hook

On April 18, 2014, 6:53 p.m., Miquel SabatĂŠ SolĂ  wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117634/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 6:53 p.m.)
> 
> 
> Review request for Kate, Michal Humpula and Simon St James.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> As promised in a previous review request, I've implemented the Ctrl-u and Ctrl-w \
> commands in replace mode. 
> 
> Diffs
> -----
> 
> autotests/src/vimode/modes.cpp 8d493ff 
> src/vimode/katevireplacemode.h 9295cb8 
> src/vimode/katevireplacemode.cpp b6dce40 
> 
> Diff: https://git.reviewboard.kde.org/r/117634/diff/
> 
> 
> Testing
> -------
> 
> All tests are passing. Some additional tests have been provided.
> 
> 
> Thanks,
> 
> Miquel SabatĂŠ SolĂ 
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117634/">https://git.reviewboard.kde.org/r/117634/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 660ae669390a4bd7a4111f0023c82e70b55fa49e by Miquel SabatĂŠ to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On April 18th, 2014, 6:53 p.m. UTC, Miquel SabatĂŠ SolĂ  wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate, Michal Humpula and Simon St James.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated April 18, 2014, 6:53 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As promised in a previous review request, I&#39;ve implemented the \
Ctrl-u and Ctrl-w commands in replace mode.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests are passing. Some additional tests have been provided.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/src/vimode/modes.cpp <span style="color: grey">(8d493ff)</span></li>

 <li>src/vimode/katevireplacemode.h <span style="color: grey">(9295cb8)</span></li>

 <li>src/vimode/katevireplacemode.cpp <span style="color: grey">(b6dce40)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117634/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 