[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 117618: vimode: cleaning up the KateViReplaceMode class.
From: Miquel_Sabaté_Solà <mikisabate () gmail ! com>
Date: 2014-04-18 8:27:39
Message-ID: 20140418082739.11639.51681 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117618/
-----------------------------------------------------------
(Updated April 18, 2014, 8:27 a.m.)
Status
------
This change has been marked as submitted.
Review request for Kate, Michal Humpula and Simon St James.
Repository: ktexteditor
Description
-------
This patch cleans up the KateViReplaceMode class a bit. In particular:
- Added documentation.
- Added proper class access modifiers for the diferent functions implemented by this \
class (not everything has to be public :P).
- In the commandInsertFromLine method I've replaced the getCharAtVirtualColumn call \
for doc()->characterAt. It's cleaner and less cumbersome :)
- Cleaned up the includes.
Diffs
-----
src/vimode/katevireplacemode.h cf67ebb
src/vimode/katevireplacemode.cpp 5b3018c
Diff: https://git.reviewboard.kde.org/r/117618/diff/
Testing
-------
All tests are passing.
Thanks,
Miquel Sabaté SolÃ
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117618/">https://git.reviewboard.kde.org/r/117618/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate, Michal Humpula and Simon St James.</div>
<div>By Miquel Sabaté Solà .</div>
<p style="color: grey;"><i>Updated April 18, 2014, 8:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch cleans up the KateViReplaceMode class a bit. In particular:
- Added documentation.
- Added proper class access modifiers for the diferent functions implemented by this \
class (not everything has to be public :P).
- In the commandInsertFromLine method I've replaced the getCharAtVirtualColumn \
call for doc()->characterAt. It's cleaner and less cumbersome \
:)
- Cleaned up the includes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests are passing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/vimode/katevireplacemode.h <span style="color: grey">(cf67ebb)</span></li>
<li>src/vimode/katevireplacemode.cpp <span style="color: grey">(5b3018c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117618/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic