'Re: Review Request 115545: Do not request text hints when the mouse cursor is behind the end of the '

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115545: Do not request text hints when the mouse cursor is behind the end of the 
From:       "Commit Hook" <null () kde ! org>
Date:       2014-04-17 18:45:07
Message-ID: 20140417184507.11639.58408 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115545/#review55980
-----------------------------------------------------------

This review has been submitted with commit 5563b89bb1817dc17497cedb6c869dc405900f36 \
by Sven Brauch to branch master.

- Commit Hook

On Feb. 9, 2014, 6:50 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115545/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2014, 6:50 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> As title says. I don't think there's a situation where this makes sense, and it \
> breaks a feature in KDevelop which is hard to fix there ;) 
> 
> Diffs
> -----
> 
> part/render/katerenderer.h d6b08a3a50c0df150dea9f562a4e1f6af5636916 
> part/view/kateviewinternal.cpp c4aaf365e40a0a8701e59a7e214d4141c17e4c25 
> tests/kateview_test.h b37d3f0b005654684ad4fcd84c9ae03cf58c6e39 
> tests/kateview_test.cpp e2369e0a2eb33f2f45b5af3ef6216f7faa076fc0 
> 
> Diff: https://git.reviewboard.kde.org/r/115545/diff/
> 
> 
> Testing
> -------
> 
> Verified that requesting text hints still works for the last character of a line.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115545/">https://git.reviewboard.kde.org/r/115545/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5563b89bb1817dc17497cedb6c869dc405900f36 by Sven Brauch to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On February 9th, 2014, 6:50 p.m. UTC, Sven Brauch wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Sven Brauch.</div>

<p style="color: grey;"><i>Updated Feb. 9, 2014, 6:50 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As title says. I don&#39;t think there&#39;s a situation where this \
makes sense, and it breaks a feature in KDevelop which is hard to fix there ;) </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Verified that requesting text hints still works for the last character \
of a line.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/render/katerenderer.h <span style="color: \
grey">(d6b08a3a50c0df150dea9f562a4e1f6af5636916)</span></li>

 <li>part/view/kateviewinternal.cpp <span style="color: \
grey">(c4aaf365e40a0a8701e59a7e214d4141c17e4c25)</span></li>

 <li>tests/kateview_test.h <span style="color: \
grey">(b37d3f0b005654684ad4fcd84c9ae03cf58c6e39)</span></li>

 <li>tests/kateview_test.cpp <span style="color: \
grey">(e2369e0a2eb33f2f45b5af3ef6216f7faa076fc0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115545/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 