[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 117571: For syntax highlighting, allow .js-files to start with a shebang
From: "Joseph Wenninger" <kde () jowenn ! at>
Date: 2014-04-16 11:20:56
Message-ID: 20140416112056.11639.37475 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117571/#review55861
-----------------------------------------------------------
Ship it!
I think this looks right now
- Joseph Wenninger
On April 16, 2014, 6:12 a.m., Magnus Hoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117571/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 6:12 a.m.)
>
>
> Review request for Kate.
>
>
> Bugs: 325805
> http://bugs.kde.org/show_bug.cgi?id=325805
>
>
> Repository: kate
>
>
> Description
> -------
>
> When writing node.js scripts it is common to include a shebang at the top, like \
> `#!/usr/bin/env node`, and save it in a .js-file. However, the syntax highlighter \
> for JavaScript does not understand the shebang, and tries to highlight it as \
> JavaScript.
> It is understood as two literal regular expressions (/usr/bin and /env node), the \
> last of which is not closed, meaning that the rest of the file is attempted \
> understood as part of the last regular expression.
> This defeats syntax highlighting for .js-files that start with a shebang.
>
> This patch allows .js files to start with a shebang.
>
> This fixes https://bugs.kde.org/show_bug.cgi?id=325805
>
>
> Diffs
> -----
>
> part/syntax/data/javascript.xml 260aa72
> part/syntax/data/html.xml 756fa8f
> part/syntax/data/djangotemplate.xml 5189f86
> part/syntax/data/coffee.xml 043e51b
> part/syntax/data/rhtml.xml d4a21ba
> part/syntax/data/qml.xml 6fa6a40
> part/syntax/data/php.xml b7d30b7
> part/syntax/data/mediawiki.xml 6c56ac9
> part/syntax/data/mako.xml cfac839
>
> Diff: https://git.reviewboard.kde.org/r/117571/diff/
>
>
> Testing
> -------
>
> I've been using this patch locally, and it works.
>
>
> Thanks,
>
> Magnus Hoff
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117571/">https://git.reviewboard.kde.org/r/117571/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this looks right \
now</pre> <br />
<p>- Joseph Wenninger</p>
<br />
<p>On April 16th, 2014, 6:12 a.m. UTC, Magnus Hoff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Magnus Hoff.</div>
<p style="color: grey;"><i>Updated April 16, 2014, 6:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325805">325805</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When writing node.js scripts it is common to include a shebang at the \
top, like `#!/usr/bin/env node`, and save it in a .js-file. However, the syntax \
highlighter for JavaScript does not understand the shebang, and tries to highlight it \
as JavaScript.
It is understood as two literal regular expressions (/usr/bin and /env node), the \
last of which is not closed, meaning that the rest of the file is attempted \
understood as part of the last regular expression.
This defeats syntax highlighting for .js-files that start with a shebang.
This patch allows .js files to start with a shebang.
This fixes https://bugs.kde.org/show_bug.cgi?id=325805</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've been using this patch locally, and it works.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/syntax/data/javascript.xml <span style="color: grey">(260aa72)</span></li>
<li>part/syntax/data/html.xml <span style="color: grey">(756fa8f)</span></li>
<li>part/syntax/data/djangotemplate.xml <span style="color: \
grey">(5189f86)</span></li>
<li>part/syntax/data/coffee.xml <span style="color: grey">(043e51b)</span></li>
<li>part/syntax/data/rhtml.xml <span style="color: grey">(d4a21ba)</span></li>
<li>part/syntax/data/qml.xml <span style="color: grey">(6fa6a40)</span></li>
<li>part/syntax/data/php.xml <span style="color: grey">(b7d30b7)</span></li>
<li>part/syntax/data/mediawiki.xml <span style="color: grey">(6c56ac9)</span></li>
<li>part/syntax/data/mako.xml <span style="color: grey">(cfac839)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117571/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic