'Re: Review Request 117203: Requiring Python 3.4 since all KF5 distros will have it anyway'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 117203: Requiring Python 3.4 since all KF5 distros will have it anyway
From:       "Phil Schaf" <flying-sheep () web ! de>
Date:       2014-03-31 12:26:18
Message-ID: 20140331122618.20888.12323 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117203/
-----------------------------------------------------------

(Updated March 31, 2014, 12:26 p.m.)

Review request for Kate.

Changes
-------

i have no idea what reviewboard did, but that's the real diff…

Repository: kate

Description
-------

Let's do this.

If you don't have python 3.4 on your dev machine yet, I'm sorry, but that shouldn't \
influence our decision:

Better build Python 3.4 on the dev machine now than us having to think needless \
backwards compatibility thoughts later, because when KF5 is finished and in a distro, \
Python 3.4 will, as well!

Diffs (updated)
-----

  addons/pate/src/utilities.cpp 6e012d3 
  addons/pate/src/engine.cpp 13d527f 
  addons/pate/CMakeLists.txt 4d8adcb 

Diff: https://git.reviewboard.kde.org/r/117203/diff/

Testing
-------

None, since I haven't gotten Kate to build yet with the KF5 setup

Thanks,

Phil Schaf

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117203/">https://git.reviewboard.kde.org/r/117203/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Phil Schaf.</div>

<p style="color: grey;"><i>Updated March 31, 2014, 12:26 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i have no idea what reviewboard did, but that's the real diff…</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Let's do this.

If you don't have python 3.4 on your dev machine yet, I'm sorry, but that shouldn't \
influence our decision:

Better build Python 3.4 on the dev machine now than us having to think needless \
backwards compatibility thoughts later, because when KF5 is finished and in a distro, \
Python 3.4 will, as well!</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None, since I haven't gotten Kate to build yet with the KF5 setup</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>addons/pate/src/utilities.cpp <span style="color: grey">(6e012d3)</span></li>

 <li>addons/pate/src/engine.cpp <span style="color: grey">(13d527f)</span></li>

 <li>addons/pate/CMakeLists.txt <span style="color: grey">(4d8adcb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117203/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 