'Re: Review Request 117130: vimode: implemented the z., z<return>, zt, z-, zb commands.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 117130: vimode: implemented the z., z<return>, zt, z-, zb commands.
From:       "Commit Hook" <null () kde ! org>
Date:       2014-03-28 20:27:26
Message-ID: 20140328202726.10710.29228 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117130/#review54501
-----------------------------------------------------------

This review has been submitted with commit 28a9bc77e986b6589056059a2e4a6f1c08b8ed92 \
by Miquel SabatĂŠ to branch master.

- Commit Hook

On March 28, 2014, 8:20 p.m., Miquel SabatĂŠ SolĂ  wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117130/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 8:20 p.m.)
> 
> 
> Review request for Kate, Michal Humpula and Simon St James.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> It's been a while since review #116657 and I decided to give it a shot :P I've \
> added more commands amd I've added tests for it. All of these commands are now \
> working both in normal and visual mode as expected. Moreover, I think that these \
> are the only scrolling commands that are worth implementing in vimode (apart from \
> the already implemented zz, of course :P), so I don't plan to implement other \
> scrolling commands :) 
> 
> Diffs
> -----
> 
> autotests/src/vimode/main.h e55741c 
> autotests/src/vimode/main.cpp 038c408 
> src/vimode/katevinormalmode.h 571c308 
> src/vimode/katevinormalmode.cpp 24da555 
> src/vimode/katevivisualmode.cpp e381539 
> 
> Diff: https://git.reviewboard.kde.org/r/117130/diff/
> 
> 
> Testing
> -------
> 
> Manual testing. I've added tests for this in a new method called \
> ViModeTest::ScrollViewTests. The tests are a bit tricky, but at least they are \
> passing for me :) Basically, for each command I test that: 
> - The line hasn't changed.
> - The column changes for the z<return>, z. and z- commands.
> - The visible range is more or less as expected. Numbers here are a bit hardcoded \
> (they depend on the hardcoded size of (200, 200) in the kate_view), but they make \
> sense. 
> 
> Thanks,
> 
> Miquel SabatĂŠ SolĂ 
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117130/">https://git.reviewboard.kde.org/r/117130/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 28a9bc77e986b6589056059a2e4a6f1c08b8ed92 by Miquel SabatĂŠ to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On March 28th, 2014, 8:20 p.m. UTC, Miquel SabatĂŠ SolĂ  wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate, Michal Humpula and Simon St James.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated March 28, 2014, 8:20 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It&#39;s been a while since review #116657 and I decided to give it a \
shot :P I&#39;ve added more commands amd I&#39;ve added tests for it. All of these \
commands are now working both in normal and visual mode as expected. Moreover, I \
think that these are the only scrolling commands that are worth implementing in \
vimode (apart from the already implemented zz, of course :P), so I don&#39;t plan to \
implement other scrolling commands :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual testing. I&#39;ve added tests for this in a new method called \
ViModeTest::ScrollViewTests. The tests are a bit tricky, but at least they are \
passing for me :) Basically, for each command I test that:

- The line hasn&#39;t changed.
- The column changes for the z&lt;return&gt;, z. and z- commands.
- The visible range is more or less as expected. Numbers here are a bit hardcoded \
(they depend on the hardcoded size of (200, 200) in the kate_view), but they make \
sense.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/src/vimode/main.h <span style="color: grey">(e55741c)</span></li>

 <li>autotests/src/vimode/main.cpp <span style="color: grey">(038c408)</span></li>

 <li>src/vimode/katevinormalmode.h <span style="color: grey">(571c308)</span></li>

 <li>src/vimode/katevinormalmode.cpp <span style="color: grey">(24da555)</span></li>

 <li>src/vimode/katevivisualmode.cpp <span style="color: grey">(e381539)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117130/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 