'Re: Review Request 116932: Added new line at end of files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 116932: Added new line at end of files
From:       "Harsh Kumar" <harsh1kumar () gmail ! com>
Date:       2014-03-26 21:57:55
Message-ID: 20140326215755.18781.65428 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116932/
-----------------------------------------------------------

(Updated March 26, 2014, 9:57 p.m.)

Status
------

This change has been discarded.

Review request for Kate.

Repository: kate

Description
-------

New line was missing at the end of a few files.

Diffs
-----

  addons/kate/replicode/replicodeconfigpage.h 3fdeda5 
  addons/kate/replicode/replicodeconfig.h 4de7179 
  addons/kate/replicode/replicodeconfigpage.cpp a8d4278 
  addons/ktexteditor/lumen/completion.h 03d2834 
  addons/ktexteditor/lumen/completion.cpp 4729c02 
  addons/ktexteditor/lumen/dcd.h 679b50e 
  addons/ktexteditor/lumen/dcd.cpp 2b2dd66 
  tests/kateview_test.cpp a24c3bf 

Diff: https://git.reviewboard.kde.org/r/116932/diff/

Testing
-------

Thanks,

Harsh Kumar

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116932/">https://git.reviewboard.kde.org/r/116932/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Harsh Kumar.</div>

<p style="color: grey;"><i>Updated March 26, 2014, 9:57 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New line was missing at the end of a few files.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>addons/kate/replicode/replicodeconfigpage.h <span style="color: \
grey">(3fdeda5)</span></li>

 <li>addons/kate/replicode/replicodeconfig.h <span style="color: \
grey">(4de7179)</span></li>

 <li>addons/kate/replicode/replicodeconfigpage.cpp <span style="color: \
grey">(a8d4278)</span></li>

 <li>addons/ktexteditor/lumen/completion.h <span style="color: \
grey">(03d2834)</span></li>

 <li>addons/ktexteditor/lumen/completion.cpp <span style="color: \
grey">(4729c02)</span></li>

 <li>addons/ktexteditor/lumen/dcd.h <span style="color: grey">(679b50e)</span></li>

 <li>addons/ktexteditor/lumen/dcd.cpp <span style="color: grey">(2b2dd66)</span></li>

 <li>tests/kateview_test.cpp <span style="color: grey">(a24c3bf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116932/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 