'Re: Review Request 116947: ktexteditor: Constructors with one argument made explicit'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 116947: ktexteditor: Constructors with one argument made explicit
From:       "Harsh Kumar" <harsh1kumar () gmail ! com>
Date:       2014-03-24 7:11:03
Message-ID: 20140324071103.31758.41829 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116947/
-----------------------------------------------------------

(Updated March 24, 2014, 7:11 a.m.)

Status
------

This change has been discarded.

Review request for Kate.

Repository: kate

Description
-------

Constructors with one argument should be made explicit unless there is a requirement \
for implicit conversion. Making such constructors explicit would avoid wrong implicit \
conversions.

Diffs
-----

  ktexteditor/factory.h 4a6e6fe 
  ktexteditor/loadsavefiltercheckplugin.h 92a6c99 
  ktexteditor/messageinterface.h b80dd1e 
  ktexteditor/plugin.h 38540ae 
  ktexteditor/view.h acf8360 
  ktexteditor/codecompletionmodel.h 07b25f2 
  ktexteditor/configpage.h 81175ed 
  ktexteditor/document.h ce463f8 
  ktexteditor/documentadaptor_p.h 3a84196 
  ktexteditor/editor.h d6806a4 
  ktexteditor/editorchooser.h ebc51f7 

Diff: https://git.reviewboard.kde.org/r/116947/diff/

Testing
-------

Compiled.

If there was any use of constructor for implicit conversion, it would have given \
compile time error. There was no error in compiling.

Thanks,

Harsh Kumar

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116947/">https://git.reviewboard.kde.org/r/116947/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Harsh Kumar.</div>

<p style="color: grey;"><i>Updated March 24, 2014, 7:11 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Constructors with one argument should be made explicit unless there is a \
requirement for implicit conversion. Making such constructors explicit would avoid \
wrong implicit conversions.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled.

If there was any use of constructor for implicit conversion, it would have given \
compile time error. There was no error in compiling.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ktexteditor/factory.h <span style="color: grey">(4a6e6fe)</span></li>

 <li>ktexteditor/loadsavefiltercheckplugin.h <span style="color: \
grey">(92a6c99)</span></li>

 <li>ktexteditor/messageinterface.h <span style="color: grey">(b80dd1e)</span></li>

 <li>ktexteditor/plugin.h <span style="color: grey">(38540ae)</span></li>

 <li>ktexteditor/view.h <span style="color: grey">(acf8360)</span></li>

 <li>ktexteditor/codecompletionmodel.h <span style="color: \
grey">(07b25f2)</span></li>

 <li>ktexteditor/configpage.h <span style="color: grey">(81175ed)</span></li>

 <li>ktexteditor/document.h <span style="color: grey">(ce463f8)</span></li>

 <li>ktexteditor/documentadaptor_p.h <span style="color: grey">(3a84196)</span></li>

 <li>ktexteditor/editor.h <span style="color: grey">(d6806a4)</span></li>

 <li>ktexteditor/editorchooser.h <span style="color: grey">(ebc51f7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116947/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 