'Re: Review Request 116992: Cursor and Range: constexpr and noexcept'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 116992: Cursor and Range: constexpr and noexcept
From:       "Dominik Haumann" <dhaumann () kde ! org>
Date:       2014-03-23 17:55:26
Message-ID: 20140323175526.11844.87674 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116992/
-----------------------------------------------------------

(Updated March 23, 2014, 5:55 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate.

Repository: ktexteditor

Description
-------

This patch adds Q_DECL_CONSTEXPR and Q_DECL_NOEXCEPT to the KTextEditor::Cursor and \
Range classes where possible. I'm not sure this patch is correct, hence the review.

Unfortunately, we cannot make Range::invalid() a constexpr, because the Range \
constructor has a body that swaps the cursors if necessary. Therefore the body is \
non-empty and constexpr is not possible anymore.

Diffs
-----

  src/include/ktexteditor/cursor.h 4c80c4e 
  src/include/ktexteditor/range.h 2956883 
  src/utils/range.cpp 6c658b3 

Diff: https://git.reviewboard.kde.org/r/116992/diff/

Testing
-------

Compiles without warning.

Thanks,

Dominik Haumann

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116992/">https://git.reviewboard.kde.org/r/116992/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Dominik Haumann.</div>

<p style="color: grey;"><i>Updated March 23, 2014, 5:55 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds Q_DECL_CONSTEXPR and Q_DECL_NOEXCEPT to the \
KTextEditor::Cursor and Range classes where possible. I&#39;m not sure this patch is \
correct, hence the review.

Unfortunately, we cannot make Range::invalid() a constexpr, because the Range \
constructor has a body that swaps the cursors if necessary. Therefore the body is \
non-empty and constexpr is not possible anymore.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles without warning.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/include/ktexteditor/cursor.h <span style="color: grey">(4c80c4e)</span></li>

 <li>src/include/ktexteditor/range.h <span style="color: grey">(2956883)</span></li>

 <li>src/utils/range.cpp <span style="color: grey">(6c658b3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116992/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 