From kwrite-devel Mon Mar 03 21:46:38 2014 From: "Matthew Woehlke" Date: Mon, 03 Mar 2014 21:46:38 +0000 To: kwrite-devel Subject: Re: Review Request 115544: improve highlighting of reStructuredText Message-Id: <20140303214638.26655.48388 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=139388322630049 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6272336872814517563==" --===============6272336872814517563== Content-Type: multipart/alternative; boundary="===============5725063313281832957==" --===============5725063313281832957== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115544/ ----------------------------------------------------------- (Updated March 3, 2014, 9:46 p.m.) Status ------ This change has been marked as submitted. Review request for Kate and Stephen Kelly. Repository: kate Description ------- There are quite some improvements; see the git log for details. @skelly, I noticed you don't have a copyright/authorship line here... should you? Diffs ----- .gitlog PRE-CREATION examples/syntax/highlight.rst PRE-CREATION part/syntax/data/rest.xml 76c476a7a1f0b774ccabf0f48a518b413b9e63e4 Diff: https://git.reviewboard.kde.org/r/115544/diff/ Testing ------- Test Content ------------ .. code-block:: c++ // This is C++ code class Foo { int bar; }; .. code-block:: python # This is Python code class Foo(object): def __init__(self): pass :This: ...is a field. :An *exciting* field: Isn't it, though? :A ``literal`` like this: ...is often used in e.g. CMake documentation. :This: ...is also a field. :: I hope I am code, and not a field! :role:`text` is not a field. Nor is :role:`text`. But `text`:role: should also be a role. This text [here] should not be special, but [this]_ is a footnote. This [isn't]_ a footnote; no special characters allowed! * Let's try some indented stuff... :: I should be code! And I should *not* be code! * Still a list. A literal ``example``:: Working? This *is* a .. code-block:: ...but ".. code-block" is normal text. .. This is a comment, which should highlight things like ALERT. This is still the comment. This is not the comment. .. Kate doesn't seem to recognize modelines in reST, though? Thanks, Matthew Woehlke --===============5725063313281832957== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115544/

This change has been marked as submitted.

Review request for Kate and Stephen Kelly.
By Matthew Woehlke.

Updated March 3, 2014, 9:46 p.m.

Repository: kate

Description 

There are quite some improvements; see the git log for details.

@skelly, I noticed you don't have a copyright/authorship line here... should you?

Testing 

Test Content
------------

.. code-block:: c++
    // This is C++ code
    class Foo { int bar; };

.. code-block:: python
    # This is Python code
    class Foo(object):
        def __init__(self):
            pass

:This: ...is a field.
:An *exciting* field: Isn't it, though?
:A ``literal`` like this: ...is often used in e.g. CMake documentation.

:This:
  ...is also a field.

::
    I hope I am code, and not a field!

:role:`text` is not a field.
Nor is :role:`text`. But `text`:role: should also be a role.

This text [here] should not be special, but [this]_ is a footnote.
This [isn't]_ a footnote; no special characters allowed!

* Let's try some indented stuff...
  ::
    I should be code!

  And I should *not* be code!
* Still a list.

A literal ``example``::
    Working?

This *is* a .. code-block::
    ...but ".. code-block" is normal text.

.. This is a comment, which should highlight things like ALERT.
   This is still the comment.

This is not the comment.

.. Kate doesn't seem to recognize modelines in reST, though?

Diffs

  • .gitlog (PRE-CREATION)
  • examples/syntax/highlight.rst (PRE-CREATION)
  • part/syntax/data/rest.xml (76c476a7a1f0b774ccabf0f48a518b413b9e63e4)

View Diff
--===============5725063313281832957==-- --===============6272336872814517563== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============6272336872814517563==--