[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 116125: Always compile static lib with -fPIC
From: "Milian Wolff" <mail () milianw ! de>
Date: 2014-03-01 17:33:09
Message-ID: 20140301173309.2006.49767 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116125/#review51446
-----------------------------------------------------------
Ship it!
Ship It!
- Milian Wolff
On Feb. 27, 2014, 3:36 p.m., Kevin Funk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116125/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 3:36 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Always compile static lib with -fPIC
>
> See
> http://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012375.html
>
>
> Diffs
> -----
>
> addons/filetree/CMakeLists.txt ed88aaece9786e686f19beea99280d2873488594
>
> Diff: https://git.reviewboard.kde.org/r/116125/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Funk
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116125/">https://git.reviewboard.kde.org/r/116125/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Milian Wolff</p>
<br />
<p>On February 27th, 2014, 3:36 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2014, 3:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Always compile static lib with -fPIC
See
http://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012375.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/filetree/CMakeLists.txt <span style="color: \
grey">(ed88aaece9786e686f19beea99280d2873488594)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116125/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic