[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: [kate] part/syntax/data: Remove RST include cuz it breaks too much things!
From: Alex Turbov <i.zaufi () gmail ! com>
Date: 2014-02-27 22:58:29
Message-ID: CANktQtvyXtCc59Ua4ZmUXjSW7d2GpC8q2NDtvQX=r2_9tO0Dhg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
the message w/ attached screenshots was bounced
I've post them here http://imgur.com/4xoURT8,5FN4GgK,EFaEZn7
On Fri, Feb 28, 2014 at 2:54 AM, Matthew Woehlke
<mwoehlke.floss@gmail.com>wrote:
> (Please keep on list so others can also express an opinion.)
>
> On 2014-02-27 17:19, Alex Turbov wrote:
>
> On Fri, Feb 28, 2014 at 1:15 AM, Matthew Woehlke wrote:
>>
>>> Some warning would have been nice. I don't like this change;
>>>
>>
>> I don't like the screenshots either!
>>
>
> What screenshots? No mail that I have received on this topic makes any
> mention of screenshots AFAICT.
>
>
> we highlight doxygen in C++, why not reST in CMake?
>>>
>>
>> yeah, why not to highlight C++ in CMake? how much C++ code did you see in
>> CMake comments? (close to zero from my experience)
>> what about Doxygen commands in C++ comments in CMake comments?? that is
>> totally insane imo!
>>
>
> I didn't say it was sane. I said we should include highlighting of the
> common documentation format in the language HL.
>
>
> IMHO it would be better to remove the specific code HL's from reST than to
>>> remove reST from CMake.
>>>
>>
>> imo, there is should be some shorter subset of RST to include to CMake --
>>
>
> ...which is a lesser form of the change I proposed, no?
>
>
> I've thought that as a quick fix it is better to remove one line...
>> unfortunately I have no time (and interest) to fix RST syntax instead...
>>
>
> I'll have a look after I merge https://git.reviewboard.kde.org/r/115544/.
> I can at least remove the syntax-highlighted code detection (that's
> trivial).
>
> Now that I'm thinking about it, I can imagine it would be better to have a
> "base" reST HL and to have languages using it add their own language HL for
> code-block's.
>
> (Though... I really wish kate's HL was a little more powerful here; what I
> would really like to do is be able include the reST rules but duck-punch a
> particular context therein to have my own rules, e.g. so a generic
> code-block in CMake would have CMake HL.)
>
> --
> Matthew
>
[Attachment #5 (text/html)]
<div dir="ltr"><div>the message w/ attached screenshots was bounced<br></div>I've \
post them here <a href="http://imgur.com/4xoURT8,5FN4GgK,EFaEZn7">http://imgur.com/4xoURT8,5FN4GgK,EFaEZn7</a><br></div><div \
class="gmail_extra"> <br><br><div class="gmail_quote">On Fri, Feb 28, 2014 at 2:54 \
AM, Matthew Woehlke <span dir="ltr"><<a href="mailto:mwoehlke.floss@gmail.com" \
target="_blank">mwoehlke.floss@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> (Please keep on list so others can also express an \
opinion.)<br> <br>
On 2014-02-27 17:19, Alex Turbov wrote:<div class=""><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> On Fri, Feb 28, 2014 at 1:15 AM, Matthew Woehlke wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Some warning would have been nice. I don't like this \
change;<br> </blockquote>
<br>
I don't like the screenshots either!<br>
</blockquote>
<br></div>
What screenshots? No mail that I have received on this topic makes any mention of \
screenshots AFAICT.<div class=""><br> <br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> we highlight doxygen in C++, why \
not reST in CMake?<br> </blockquote>
<br>
yeah, why not to highlight C++ in CMake? how much C++ code did you see in<br>
CMake comments? (close to zero from my experience)<br>
what about Doxygen commands in C++ comments in CMake comments?? that is<br>
totally insane imo!<br>
</blockquote>
<br></div>
I didn't say it was sane. I said we should include highlighting of the common \
documentation format in the language HL.<div class=""><br> <br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> IMHO it would be better to remove \
the specific code HL's from reST than to<br> remove reST from CMake.<br>
</blockquote>
<br>
imo, there is should be some shorter subset of RST to include to CMake --<br>
</blockquote>
<br></div>
...which is a lesser form of the change I proposed, no?<div class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> I've thought that as a quick fix it is better to remove \
one line...<br> unfortunately I have no time (and interest) to fix RST syntax \
instead...<br> </blockquote>
<br></div>
I'll have a look after I merge <a \
href="https://git.reviewboard.kde.org/r/115544/" \
target="_blank">https://git.reviewboard.kde.<u></u>org/r/115544/</a>. I can at least \
remove the syntax-highlighted code detection (that's trivial).<br>
<br>
Now that I'm thinking about it, I can imagine it would be better to have a \
"base" reST HL and to have languages using it add their own language HL for \
code-block's.<br> <br>
(Though... I really wish kate's HL was a little more powerful here; what I would \
really like to do is be able include the reST rules but duck-punch a particular \
context therein to have my own rules, e.g. so a generic code-block in CMake would \
have CMake HL.)<span class="HOEnZb"><font color="#888888"><br>
<br>
-- <br>
Matthew<br>
</font></span></blockquote></div><br></div>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic