[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Review Request 116459: Implement new Application interfaces in kate
From: "Michal Humpula" <michal.humpula () seznam ! cz>
Date: 2014-02-27 21:01:58
Message-ID: 20140227210158.12300.45698 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116459/
-----------------------------------------------------------
Review request for Kate.
Repository: kate
Description
-------
This is attempt to implement new interface from \
https://git.reviewboard.kde.org/r/115160/. I would commit it directly, but \
it seems too ugly to me. Second opinion on this would be apreciated.
Diffs
-----
kate/src/kateapp.h beb6b1f
kate/src/kateapp.cpp b4bb0a7
kate/src/katemainwindow.h acdd56b
kate/src/kateviewmanager.h 11e8055
kate/src/kateviewmanager.cpp ae4b852
Diff: https://git.reviewboard.kde.org/r/116459/diff/
Testing
-------
Thanks,
Michal Humpula
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116459/">https://git.reviewboard.kde.org/r/116459/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is attempt to implement new interface from \
https://git.reviewboard.kde.org/r/115160/. I would commit it directly, but \
it seems too ugly to me. Second opinion on this would be apreciated.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kate/src/kateapp.h <span style="color: grey">(beb6b1f)</span></li>
<li>kate/src/kateapp.cpp <span style="color: grey">(b4bb0a7)</span></li>
<li>kate/src/katemainwindow.h <span style="color: \
grey">(acdd56b)</span></li>
<li>kate/src/kateviewmanager.h <span style="color: \
grey">(11e8055)</span></li>
<li>kate/src/kateviewmanager.cpp <span style="color: \
grey">(ae4b852)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116459/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic