From kwrite-devel Tue Feb 25 10:50:48 2014 From: "Dominik Haumann" Date: Tue, 25 Feb 2014 10:50:48 +0000 To: kwrite-devel Subject: Re: Review Request 115944: Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plug Message-Id: <20140225105048.20335.31646 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=139332546312070 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1237943288278582173==" --===============1237943288278582173== Content-Type: multipart/alternative; boundary="===============3366420577280813764==" --===============3366420577280813764== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115944/#review50792 ----------------------------------------------------------- Ship it! Looks good, please commit. addons/kate/symbolviewer/ecma_parser.cpp c += 3; // can you add these spaces? :-) - Dominik Haumann On Feb. 24, 2014, 9:13 p.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115944/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 9:13 p.m.) > > > Review request for Kate. > > > Repository: kate > > > Description > ------- > > Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plugin. > > This patch will search for a line containing "id:" and add the name as a "class" > > > Diffs > ----- > > addons/kate/symbolviewer/ecma_parser.cpp 2b96b0d > addons/kate/symbolviewer/plugin_katesymbolviewer.cpp 701f175 > > Diff: https://git.reviewboard.kde.org/r/115944/diff/ > > > Testing > ------- > > Opened a couple of QML files > > > Thanks, > > Kåre Särs > > --===============3366420577280813764== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115944/

Ship it!

Looks good, please commit.

addons/kate/symbolviewer/ecma_parser.cpp (Diff revision 2)
void KatePluginSymbolViewerView::parseEcmaSymbols(void)
		232	c+=3;

c += 3; // can you add these spaces? :-)

- Dominik Haumann

On February 24th, 2014, 9:13 p.m. UTC, Kåre Särs wrote:

Review request for Kate.

By Kåre Särs.

Updated Feb. 24, 2014, 9:13 p.m.

Repository: kate

Description

Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plugin.

This patch will search for a line containing "id:" and add the name as a "class"

Testing

Opened a couple of QML files

Diffs

addons/kate/symbolviewer/ecma_parser.cpp (2b96b0d)
addons/kate/symbolviewer/plugin_katesymbolviewer.cpp (701f175)

View Diff

--===============3366420577280813764==-- --===============1237943288278582173== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============1237943288278582173==--