From kwrite-devel Tue Feb 25 10:48:28 2014 From: "Dominik Haumann" Date: Tue, 25 Feb 2014 10:48:28 +0000 To: kwrite-devel Subject: Re: Review Request 116035: add indenter for Replicode Message-Id: <20140225104828.11047.56059 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=139332532912020 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6228280428200266781==" --===============6228280428200266781== Content-Type: multipart/alternative; boundary="===============0801515098450534544==" --===============0801515098450534544== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116035/#review50790 ----------------------------------------------------------- Ship it! Can you add unit tests for this? We have unit test for all other indenters, and although your indenter is currently very simple, I'd like to have unit tests right from the beginning. If you need help here, please ask on irc or on the mailing list. You can commit this, provided you will add unit tests :-) part/script/data/indentation/replicode.js You don't ships a replicode.po file, so just leave this empty. - Dominik Haumann On Feb. 24, 2014, 11:36 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116035/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 11:36 p.m.) > > > Review request for Kate. > > > Repository: kate > > > Description > ------- > > Adds a indenter for Replicode. > > Ideally it would use the set indent width, but the language requires three spaces indentation, and I couldn't find a way to ship a file mode file with kate/force indentation for a specific language. > > > Diffs > ----- > > part/script/data/indentation/replicode.js PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116035/diff/ > > > Testing > ------- > > wrote some code, all is good. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============0801515098450534544== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116035/

Ship it!

Can you add unit tests for this? We have unit test for all other indenters, and although your indenter is currently very simple, I'd like to have unit tests right from the beginning. If you need help here, please ask on irc or on the mailing list.

You can commit this, provided you will add unit tests :-)

part/script/data/indentation/replicode.js (Diff revision 1)
		9	* i18n-catalog: replicode

You don't ships a replicode.po file, so just leave this empty.

- Dominik Haumann

On February 24th, 2014, 11:36 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:

Review request for Kate.

By Martin Tobias Holmedahl Sandsmark.

Updated Feb. 24, 2014, 11:36 p.m.

Repository: kate

Description

Adds a indenter for Replicode.

Ideally it would use the set indent width, but the language requires three spaces indentation, and I couldn't find a way to ship a file mode file with kate/force indentation for a specific language.

Testing

wrote some code, all is good.

Diffs

part/script/data/indentation/replicode.js (PRE-CREATION)

--===============0801515098450534544==-- --===============6228280428200266781== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============6228280428200266781==--