--===============0541907335463195236== Content-Type: multipart/alternative; boundary="===============2018850790113112306==" --===============2018850790113112306== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115944/#review50582 ----------------------------------------------------------- addons/kate/symbolviewer/ecma_parser.cpp if (stripped.midRef(c, 3) == QLatin1String("id:")) addons/kate/symbolviewer/ecma_parser.cpp stripped.remove(0, 3) - Milian Wolff On Feb. 21, 2014, 9:07 p.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115944/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 9:07 p.m.) > > > Review request for Kate. > > > Repository: kate > > > Description > ------- > > Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plugin. > > This patch will search for a line containing "id:" and add the name as a "class" > > > Diffs > ----- > > addons/kate/symbolviewer/ecma_parser.cpp 2b96b0d > addons/kate/symbolviewer/plugin_katesymbolviewer.cpp 701f175 > > Diff: https://git.reviewboard.kde.org/r/115944/diff/ > > > Testing > ------- > > Opened a couple of QML files > > > Thanks, > > Kåre Särs > > --===============2018850790113112306== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115944/

addons/kate/symbolviewer/ecma_parser.cpp (Diff revision 1)
void KatePluginSymbolViewerView::parseEcmaSymbols(void)
		231	if ((current == 'i') && (stripped.indexOf("id:", c) == c)) {

if (stripped.midRef(c, 3) == QLatin1String("id:"))

addons/kate/symbolviewer/ecma_parser.cpp (Diff revision 1)
void KatePluginSymbolViewerView::parseEcmaSymbols(void)
		233	stripped = stripped.mid(3);

stripped.remove(0, 3)

- Milian Wolff

On February 21st, 2014, 9:07 p.m. UTC, Kåre Särs wrote:

Review request for Kate.

By Kåre Särs.

Updated Feb. 21, 2014, 9:07 p.m.

Repository: kate

Description

Add QML and QML-"id:" support to the ecma_parser of the SymbolViewer plugin.

This patch will search for a line containing "id:" and add the name as a "class"

Testing

Opened a couple of QML files

Diffs

addons/kate/symbolviewer/ecma_parser.cpp (2b96b0d)
addons/kate/symbolviewer/plugin_katesymbolviewer.cpp (701f175)

--===============2018850790113112306==-- --===============0541907335463195236== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============0541907335463195236==--