--===============5943415693269817791== Content-Type: multipart/alternative; boundary="===============5469942675419633470==" --===============5469942675419633470== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114896/ ----------------------------------------------------------- (Updated Feb. 22, 2014, 8:42 p.m.) Status ------ This change has been discarded. Review request for Kate. Bugs: 329629 http://bugs.kde.org/show_bug.cgi?id=329629 Repository: kate Description ------- It's not done very nicely, but it succesfully ditches the endless loop. The result is "command unsuccessful" instead. Though vim behaviour is more expectable, it's not that easy to mimic (usually breaking the s/$/x/ case). The other question would be, where to put tests? In tests/commands_test.cpp? Diffs ----- part/search/kateregexpsearch.cpp 0f4d42c Diff: https://git.reviewboard.kde.org/r/114896/diff/ Testing ------- make tests are passing Thanks, Michal Humpula --===============5469942675419633470== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114896/ |
This change has been discarded. |
Review request for Kate.
By Michal Humpula.
Updated Feb. 22, 2014, 8:42 p.m.
Bugs:
329629
Repository:
kate
Description
Testing
Diffs
|