This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114896/

This change has been discarded.


Review request for Kate.
By Michal Humpula.

Updated Feb. 22, 2014, 8:42 p.m.

Bugs: 329629
Repository: kate

Description

It's not done very nicely, but it succesfully ditches the endless loop. The result is "command unsuccessful" instead. Though vim behaviour is more expectable, it's not that easy to mimic (usually breaking the s/$/x/ case).

The other question would be, where to put tests? In tests/commands_test.cpp?

Testing

make tests are passing

Diffs

  • part/search/kateregexpsearch.cpp (0f4d42c)

View Diff