[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115928: Auto-adapt hardcoded colors to current color scheme
From: "Milian Wolff" <mail () milianw ! de>
Date: 2014-02-22 17:32:00
Message-ID: 20140222173200.7230.6955 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115928/#review50545
-----------------------------------------------------------
part/syntax/katehighlight.cpp
<https://git.reviewboard.kde.org/r/115928/#comment35562>
I'll push these changes as a separate commit if someone wants to. Otherwise I'll \
keep it in this patch for simplicity.
- Milian Wolff
On Feb. 22, 2014, 5:28 p.m., Milian Wolff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115928/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 5:28 p.m.)
>
>
> Review request for Kate and Christoph Cullmann.
>
>
> Repository: kate
>
>
> Description
> -------
>
> This code is used like that for years in KDevelop and works quite
> nicely for most cases.
>
> Note that for darker color schemes, this most often results in
> a bit less-intense colors which is not a big problem as colors stand
> out much more against a dark background. And its better than before,
> where you'd end up with hard-coded colors for a bright background
> scheme...
>
> Bright color schemes are not affected, as long as they fulfill the
> conditition of having a lower luma for the background color compared
> to the foreground color.
>
>
> Diffs
> -----
>
> part/syntax/katehighlight.cpp 1ae649d
> part/utils/katedefaultcolors.h 19fc2f9
> part/utils/katedefaultcolors.cpp bb1c60b
>
> Diff: https://git.reviewboard.kde.org/r/115928/diff/
>
>
> Testing
> -------
>
> Created a new kate scheme with a dark and with a bright system color scheme. The \
> bright one stayed as-is. The dark one auto-adapted all colors - even those \
> hardcoded in highlighting .xml files!
> The result is an always-readable text on dark schemes, where previously hard coded \
> colors lead to unreadable mess which one had to fix manually...
>
> File Attachments
> ----------------
>
> LaTeX without adaption
> https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/aea5478c-0cf8-4dfe-9f4f-350faf2db5f6__kate-no-adapt-latex.png
> LaTeX with adaption
> https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/a1fcec62-1815-4874-964e-58d3ae240606__kate-auto-adapt-latex.png
>
>
> Thanks,
>
> Milian Wolff
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115928/">https://git.reviewboard.kde.org/r/115928/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115928/diff/2/?file=245545#file245545line626" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/syntax/katehighlight.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KateHighlighting::getKateExtendedAttributeList (const QString &schema, \
QList<KateExtendedAttribute::Ptr> &list, KConfig* cfg)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">625</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QRgb</span> <span class="n">col</span><span class="p">;</span></pre></td> \
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll \
push these changes as a separate commit if someone wants to. Otherwise I'll keep \
it in this patch for simplicity.</pre> </div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On February 22nd, 2014, 5:28 p.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2014, 5:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> This code is used like that for years in KDevelop and works quite \
nicely for most cases.
Note that for darker color schemes, this most often results in
a bit less-intense colors which is not a big problem as colors stand
out much more against a dark background. And its better than before,
where you'd end up with hard-coded colors for a bright background
scheme...
Bright color schemes are not affected, as long as they fulfill the
conditition of having a lower luma for the background color compared
to the foreground color.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created a new kate scheme with a dark and with a bright system color \
scheme. The bright one stayed as-is. The dark one auto-adapted all colors - even \
those hardcoded in highlighting .xml files!
The result is an always-readable text on dark schemes, where previously hard coded \
colors lead to unreadable mess which one had to fix manually...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/syntax/katehighlight.cpp <span style="color: grey">(1ae649d)</span></li>
<li>part/utils/katedefaultcolors.h <span style="color: grey">(19fc2f9)</span></li>
<li>part/utils/katedefaultcolors.cpp <span style="color: grey">(bb1c60b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115928/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/aea5478c-0cf8-4dfe-9f4f-350faf2db5f6__kate-no-adapt-latex.png">LaTeX \
without adaption</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/20/a1fcec62-1815-4874-964e-58d3ae240606__kate-auto-adapt-latex.png">LaTeX \
with adaption</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic