[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115926: Refactor and centralize default-color generation into a central place
From: "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date: 2014-02-21 15:08:24
Message-ID: 20140221150824.27042.63803 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 20, 2014, 5:40 p.m., Matthew Woehlke wrote:
> > part/utils/katedefaultcolors.cpp, lines 68-71
> > <https://git.reviewboard.kde.org/r/115926/diff/2/?file=245164#file245164line68>
> >
> > Can someone remind me what was wrong with {Neutral,Positive}Background here? \
> > Maybe not the place to change it in this patch but I do feel a little itchy that \
> > the comments what these "should" be are now gone too.
>
> Dominik Haumann wrote:
> Afaik, these colors are so decent that it somehow wasn't bold enough. But I may be \
> wrong.
> Milian Wolff wrote:
> re-added the comment that this should/must be adapted to the color scheme (which is \
> the whole point of why I started working on this).
> Matthew Woehlke wrote:
> @Dominik, that sounds suspiciously like my own hazy recollection, it's probably \
> right.
> @Milian, maybe these should come from a tint (or even a blend) of the foreground \
> color the same way the scheme background colors do, but with a stronger tint \
> applied. (FWIW, since this reminded me to go and fix my scheme so these are \
> actually legible, what I ended up going with was a somewhat modestly tint of \
> Active. I liked that better than Neutral, but my Active is of a cyan hue; for \
> schemes that have a magenta Active that might not work.)
> Milian Wolff wrote:
> As I said, I don't want to do this in this patch, but will look into auto-tinting \
> in a follow-up commit.
> Christoph Cullmann wrote:
> Yeah, the color scheme variants were not visible enough in most KDE provided color \
> schemes at all.
@Milian, sorry for being unclear; I also didn't mean to do it in this patch :-). \
Apologies for the misunderstanding.
@Christoph, thanks for confirming.
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115926/#review50414
-----------------------------------------------------------
On Feb. 20, 2014, 6:10 p.m., Milian Wolff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115926/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 6:10 p.m.)
>
>
> Review request for Kate and Christoph Cullmann.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Instead of copy'n'pasting the generation of default colors, we put that into a
> central place and generate the colors there.
>
> Building on top of this patch, I plan to add some auto-tinting code as I use in
> KDevelop for the currently hardcoded colors (see Qt::yellow & friends).
>
> Please accept this for KDE4, as it's a bug fix for people like me.
>
>
> Diffs
> -----
>
> part/CMakeLists.txt 737f325
> part/schema/kateschemaconfig.cpp 541be03
> part/utils/kateconfig.cpp 65e8e8e
> part/utils/katedefaultcolors.h PRE-CREATION
> part/utils/katedefaultcolors.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115926/diff/
>
>
> Testing
> -------
>
> Still looks as before to my eyes. Dunno if I regressed anything?
>
>
> Thanks,
>
> Milian Wolff
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115926/">https://git.reviewboard.kde.org/r/115926/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 20th, 2014, 5:40 p.m. EST, <b>Matthew \
Woehlke</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115926/diff/2/?file=245164#file245164line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/utils/katedefaultcolors.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="n">SearchHighlight</span>:</pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">69</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">QColor</span><span class="p">(</span><span \
class="n">Qt</span><span class="o">::</span><span class="n">yellow</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">70</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="n">ReplaceHighlight</span>:</pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">71</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">QColor</span><span class="p">(</span><span \
class="n">Qt</span><span class="o">::</span><span class="n">green</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can someone remind me \
what was wrong with {Neutral,Positive}Background here? Maybe not the place to change \
it in this patch but I do feel a little itchy that the comments what these \
"should" be are now gone too.</pre> </blockquote>
<p>On February 20th, 2014, 5:54 p.m. EST, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Afaik, these colors are \
so decent that it somehow wasn't bold enough. But I may be wrong.</pre> \
</blockquote>
<p>On February 20th, 2014, 5:57 p.m. EST, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">re-added the comment \
that this should/must be adapted to the color scheme (which is the whole point of why \
I started working on this).</pre> </blockquote>
<p>On February 20th, 2014, 6:05 p.m. EST, <b>Matthew Woehlke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Dominik, that sounds \
suspiciously like my own hazy recollection, it's probably right.
@Milian, maybe these should come from a tint (or even a blend) of the foreground \
color the same way the scheme background colors do, but with a stronger tint applied. \
(FWIW, since this reminded me to go and fix my scheme so these are actually legible, \
what I ended up going with was a somewhat modestly tint of Active. I liked that \
better than Neutral, but my Active is of a cyan hue; for schemes that have a magenta \
Active that might not work.)</pre> </blockquote>
<p>On February 20th, 2014, 6:09 p.m. EST, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I said, I don't \
want to do this in this patch, but will look into auto-tinting in a follow-up \
commit.</pre> </blockquote>
<p>On February 21st, 2014, 1:03 a.m. EST, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, the color scheme \
variants were not visible enough in most KDE provided color schemes at all.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Milian, \
sorry for being unclear; I also didn't mean to do it in this patch :-). Apologies \
for the misunderstanding.
@Christoph, thanks for confirming.</pre>
<br />
<p>- Matthew</p>
<br />
<p>On February 20th, 2014, 6:10 p.m. EST, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 6:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Instead of copy'n'pasting the generation of default colors, we \
put that into a central place and generate the colors there.
Building on top of this patch, I plan to add some auto-tinting code as I use in
KDevelop for the currently hardcoded colors (see Qt::yellow & friends).
Please accept this for KDE4, as it's a bug fix for people like me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still looks as before to my eyes. Dunno if I regressed anything?</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/CMakeLists.txt <span style="color: grey">(737f325)</span></li>
<li>part/schema/kateschemaconfig.cpp <span style="color: grey">(541be03)</span></li>
<li>part/utils/kateconfig.cpp <span style="color: grey">(65e8e8e)</span></li>
<li>part/utils/katedefaultcolors.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/utils/katedefaultcolors.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115926/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic