[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115845: syntax: add ability to specify LineContinu character
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2014-02-17 21:11:29
Message-ID: 20140217211129.430.82449 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 17, 2014, 9:06 p.m., Milian Wolff wrote:
> > A test would certainly be welcome. Could be achieved by testing the highlighting \
> > attribute for some sample text with a highlighter that makes use of this new \
> > feature?
Yes, a unit test would be welcome. But then, I'd like to see a unit test suite made \
for this, similar to what we have for the indentation:
Use a specific highlight.xml file, add a test file that uses this highlight, and \
specify somehow which defaultStyle a specific line/column should have. Something \
along this lines would be awesome, and in fact, it's long overdue we add unit tests \
here. Any volunteers? :-)
- Dominik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115845/#review50098
-----------------------------------------------------------
On Feb. 17, 2014, 8:45 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115845/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 8:45 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> This enables to use different LineContinue character other then C-like '\\'.
>
> Should there be some additional test for this?
>
>
> Diffs
> -----
>
> part/syntax/data/language.dtd a86d51f
> part/syntax/katehighlight.cpp 1a3abfa
> part/syntax/katehighlighthelpers.h 24daf7c
> part/syntax/katehighlighthelpers.cpp 9528fb1
>
> Diff: https://git.reviewboard.kde.org/r/115845/diff/
>
>
> Testing
> -------
>
> Used in own highlight file, seems to be working. The C syntax seems to be working \
> still:)
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115845/">https://git.reviewboard.kde.org/r/115845/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 17th, 2014, 9:06 p.m. UTC, <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A test would certainly be welcome. Could be achieved by testing the \
highlighting attribute for some sample text with a highlighter that makes use of this \
new feature?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, a unit test would \
be welcome. But then, I'd like to see a unit test suite made for this, similar to \
what we have for the indentation:
Use a specific highlight.xml file, add a test file that uses this highlight, and \
specify somehow which defaultStyle a specific line/column should have. Something \
along this lines would be awesome, and in fact, it's long overdue we add unit \
tests here. Any volunteers? :-)</pre> <br />
<p>- Dominik</p>
<br />
<p>On February 17th, 2014, 8:45 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2014, 8:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This enables to use different LineContinue character other then C-like \
'\\'.
Should there be some additional test for this?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used in own highlight file, seems to be working. The C syntax seems to \
be working still:)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/syntax/data/language.dtd <span style="color: grey">(a86d51f)</span></li>
<li>part/syntax/katehighlight.cpp <span style="color: grey">(1a3abfa)</span></li>
<li>part/syntax/katehighlighthelpers.h <span style="color: \
grey">(24daf7c)</span></li>
<li>part/syntax/katehighlighthelpers.cpp <span style="color: \
grey">(9528fb1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115845/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic