[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115819: syntax: puppet syntax higlight file v2.0
From: "Michal Humpula" <michal.humpula () seznam ! cz>
Date: 2014-02-17 17:55:52
Message-ID: 20140217175552.429.97287 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115819/
-----------------------------------------------------------
(Updated Feb. 17, 2014, 5:55 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate.
Repository: kate
Description
-------
This is the puppet syntax file written from scratch, a.k.a. not derived from ruby \
syntax version. The original puppet.xml posted week ago was not bad, but had some \
issues.
Written according to documentation, tested agains my own sample and wikipedia puppet \
repo (https://gerrit.wikimedia.org/r/p/operations/puppet ). It's not perfect, but \
should cover above 95% cases with codefolding and stuff. Remaining issues are marked \
in the code.
Colors could be improved greatly, thought it's usable like this. The nesting gets \
pretty ugly in some places, but considering it's a language inspired by ruby, which \
is already pretty messy, and later additionaly twisted, I guess the complexity level \
is adequate.
The indenter is specified manualy to "cstyle", because the "normal" doesn't seems to \
be aligning at all in this case and ruby indenter is locked against ruby highlight.
Diffs
-----
part/syntax/data/puppet.xml 53fc1d6
Diff: https://git.reviewboard.kde.org/r/115819/diff/
Testing
-------
Thanks,
Michal Humpula
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115819/">https://git.reviewboard.kde.org/r/115819/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2014, 5:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the puppet syntax file written from scratch, a.k.a. not derived \
from ruby syntax version. The original puppet.xml posted week ago was not bad, but \
had some issues.
Written according to documentation, tested agains my own sample and wikipedia puppet \
repo (https://gerrit.wikimedia.org/r/p/operations/puppet ). It's not perfect, but \
should cover above 95% cases with codefolding and stuff. Remaining issues are marked \
in the code.
Colors could be improved greatly, thought it's usable like this. The nesting gets \
pretty ugly in some places, but considering it's a language inspired by ruby, \
which is already pretty messy, and later additionaly twisted, I guess the complexity \
level is adequate.
The indenter is specified manualy to "cstyle", because the \
"normal" doesn't seems to be aligning at all in this case and ruby \
indenter is locked against ruby highlight.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/syntax/data/puppet.xml <span style="color: grey">(53fc1d6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115819/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic