[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: [kdevplatform] language/editor: Add porting note
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2014-02-14 11:14:56
Message-ID: 3017565.tXZEjStV09 () eriador
[Download RAW message or body]

On Thursday 13 February 2014 23:43:28 Kevin Funk wrote:
> Git commit e3d224ea1f007ad04076cb2ecba4dd522887b249 by Kevin Funk.
> Committed on 13/02/2014 at 23:43.
> Pushed by kfunk into branch 'master'.
> 
> Add porting note
> 
> M  +2    -0    language/editor/simplerange.h
> 
> http://commits.kde.org/kdevplatform/e3d224ea1f007ad04076cb2ecba4dd522887b249
> 
> diff --git a/language/editor/simplerange.h b/language/editor/simplerange.h
> index 8ff62e8..2cc70dd 100644
> --- a/language/editor/simplerange.h
> +++ b/language/editor/simplerange.h
> @@ -29,6 +29,8 @@
>   * a more efficient version of KTextEditor::Range.
>   * In KDevelop, this object is used when referencing the most current
> document revision * (the document in its current version)
> + *
> + * TODO KF5: Just use KTextEditor::Range here? Cursors are now simple
> members just like here */
> 
>  namespace KDevelop {

Yes, the only addon KDevelop's simple range and simple cursor now provide are 
hash functions:

inline uint qHash(const KDevelop::SimpleRange& range)
{
    return qHash(range.start) + qHash(range.end) * 41;
}

inline uint qHash(const KDevelop::SimpleCursor& cursor)
{
    return cursor.line * 53 + cursor.column * 47;
}

These should probably be added to ktextditor/range.h and ktexteditor/cursor.h.
It would be interesting, whether these hash functions produce good hash values 
-- no idea :-)

Greetings,
Dominik
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]