'Re: Review Request 115080: move spellcheck dialog to bottomViewBar'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115080: move spellcheck dialog to bottomViewBar
From:       "Dominik Haumann" <dhaumann () kde ! org>
Date:       2014-02-11 8:47:04
Message-ID: 20140211084704.2474.20775 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115080/#review49507
-----------------------------------------------------------

To me this patch looks good and I'd be fine with committing this. The only open issue \
is: The code from Sonnet is LGPLv2.1+, and the rest of Kate Part's source code is \
LGPLv2+.

@Christoph: What's your take on this?

- Dominik Haumann

On Feb. 8, 2014, 9:44 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115080/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2014, 9:44 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Code transforms the Sonnet::Dialog on top of ViewBarWidget. Currently the design is \
> three lines high. For previous discussion, see review #114675. 
> 
> Diffs
> -----
> 
> src/CMakeLists.txt 770dc39 
> src/spellcheck/spellcheckbar.h PRE-CREATION 
> src/spellcheck/spellcheckbar.cpp PRE-CREATION 
> src/spellcheck/spellcheckbar.ui PRE-CREATION 
> src/spellcheck/spellcheckdialog.h 832afcb 
> src/spellcheck/spellcheckdialog.cpp bf23b9d 
> 
> Diff: https://git.reviewboard.kde.org/r/115080/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115080/">https://git.reviewboard.kde.org/r/115080/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To me this patch looks \
good and I&#39;d be fine with committing this. The only open issue is: The code from \
Sonnet is LGPLv2.1+, and the rest of Kate Part&#39;s source code is LGPLv2+.

@Christoph: What&#39;s your take on this?</pre>
 <br />

<p>- Dominik Haumann</p>

<br />
<p>On February 8th, 2014, 9:44 p.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Feb. 8, 2014, 9:44 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Code transforms the Sonnet::Dialog on top of ViewBarWidget. Currently \
the design is three lines high. For previous discussion, see review #114675.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(770dc39)</span></li>

 <li>src/spellcheck/spellcheckbar.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/spellcheck/spellcheckbar.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/spellcheck/spellcheckbar.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/spellcheck/spellcheckdialog.h <span style="color: \
grey">(832afcb)</span></li>

 <li>src/spellcheck/spellcheckdialog.cpp <span style="color: \
grey">(bf23b9d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115080/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 