[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115544: fix field highlighting in reStructuredText
From: "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date: 2014-02-10 17:15:20
Message-ID: 20140210171520.2492.69998 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 8, 2014, 4:26 a.m., Stephen Kelly wrote:
> > Can you post a snippet which doesn't get highlighted properly so I can see it?
Any field list. For example:
> foo: bar
...should be highlighted as a field, but with the version in master is highlighted as \
a role.
Actually, the current rules are inadequate, since with this change, ":foo:`bar`" at \
the beginning of a line is now highlighted as a field instead of a role. So I may \
revisit this if I get a chance (or you are welcome to do so), but even in its current \
state it's an improvement.
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115544/#review49239
-----------------------------------------------------------
On Feb. 7, 2014, 3:30 p.m., Matthew Woehlke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115544/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2014, 3:30 p.m.)
>
>
> Review request for Kate and Stephen Kelly.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Swap order of field and role rules, as the latter was overriding the former and \
> causing it to never fire.
> @skelly, I noticed you don't have a copyright/authorship line here... should you?
>
>
> Diffs
> -----
>
> .gitlog PRE-CREATION
> part/syntax/data/rest.xml 76c476a7a1f0b774ccabf0f48a518b413b9e63e4
>
> Diff: https://git.reviewboard.kde.org/r/115544/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matthew Woehlke
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115544/">https://git.reviewboard.kde.org/r/115544/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 8th, 2014, 4:26 a.m. EST, <b>Stephen \
Kelly</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Can you post a snippet which doesn't get highlighted properly so I \
can see it?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any field list. For \
example:
> foo: bar
...should be highlighted as a field, but with the version in master is highlighted as \
a role.
Actually, the current rules are inadequate, since with this change, \
":foo:`bar`" at the beginning of a line is now highlighted as a field \
instead of a role. So I may revisit this if I get a chance (or you are welcome to do \
so), but even in its current state it's an improvement.</pre> <br />
<p>- Matthew</p>
<br />
<p>On February 7th, 2014, 3:30 p.m. EST, Matthew Woehlke wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Stephen Kelly.</div>
<div>By Matthew Woehlke.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2014, 3:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Swap order of field and role rules, as the latter was overriding the \
former and causing it to never fire.
@skelly, I noticed you don't have a copyright/authorship line here... should \
you?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.gitlog <span style="color: grey">(PRE-CREATION)</span></li>
<li>part/syntax/data/rest.xml <span style="color: \
grey">(76c476a7a1f0b774ccabf0f48a518b413b9e63e4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115544/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic