'Re: Review Request 114896: fix "s/\s*/ /g" loop'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114896: fix "s/\s*/ /g" loop
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2014-02-08 23:55:18
Message-ID: 20140208235518.12465.46653 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114896/#review49309
-----------------------------------------------------------

This definitely needs a test, but otherwise looks good!

thanks

- Milian Wolff

On Jan. 7, 2014, 4:26 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114896/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 4:26 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Bugs: 329629
> http://bugs.kde.org/show_bug.cgi?id=329629
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> It's not done very nicely, but it succesfully ditches the endless loop. The result \
> is "command unsuccessful" instead. Though vim behaviour is more expectable, it's \
> not that easy to mimic (usually breaking the s/$/x/ case). 
> The other question would be, where to put tests? In tests/commands_test.cpp?
> 
> 
> Diffs
> -----
> 
> part/search/kateregexpsearch.cpp 0f4d42c 
> 
> Diff: https://git.reviewboard.kde.org/r/114896/diff/
> 
> 
> Testing
> -------
> 
> make tests are passing
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114896/">https://git.reviewboard.kde.org/r/114896/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This definitely needs a \
test, but otherwise looks good!

thanks</pre>
 <br />

<p>- Milian Wolff</p>

<br />
<p>On January 7th, 2014, 4:26 p.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Jan. 7, 2014, 4:26 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=329629">329629</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It&#39;s not done very nicely, but it succesfully ditches the endless \
loop. The result is &quot;command unsuccessful&quot; instead. Though vim behaviour is \
more expectable, it&#39;s not that easy to mimic (usually breaking the s/$/x/ case).

The other question would be, where to put tests? In tests/commands_test.cpp?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">make tests are passing</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/search/kateregexpsearch.cpp <span style="color: grey">(0f4d42c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114896/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 