[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115096: asynchronous swap file
From: "Michal Humpula" <michal.humpula () seznam ! cz>
Date: 2014-02-08 19:12:53
Message-ID: 20140208191253.12465.5970 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115096/
-----------------------------------------------------------
(Updated Feb. 8, 2014, 7:12 p.m.)
Status
------
This change has been discarded.
Review request for Kate.
Repository: ktexteditor
Description
-------
Moves the swap file writing to separate thread. This way, when the storage is slow, \
it will not get in the way of editing.
It's still a little bit rough, but it seems to be working.
The only problem now is that before the user knew that syncing is lagging, because \
whole app froze. Now the user have no idea if (and how much) the sync thread is \
lagging. The question is, whether adding some message display or status bar text \
informing about lagginess wouldn't be obtrusive (or completely useless for regular \
users).
Diffs
-----
src/CMakeLists.txt fee14e8
src/swapfile/kateswapdiffcreator.cpp 3b2703b
src/swapfile/kateswapfile.h 5e4f31d
src/swapfile/kateswapfile.cpp f482af3
src/swapfile/kateswapfilewriter.h PRE-CREATION
src/swapfile/kateswapfilewriter.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115096/diff/
Testing
-------
tests are comming. So far manual run.
Thanks,
Michal Humpula
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115096/">https://git.reviewboard.kde.org/r/115096/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2014, 7:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Moves the swap file writing to separate thread. This way, when the \
storage is slow, it will not get in the way of editing.
It's still a little bit rough, but it seems to be working.
The only problem now is that before the user knew that syncing is lagging, because \
whole app froze. Now the user have no idea if (and how much) the sync thread is \
lagging. The question is, whether adding some message display or status bar text \
informing about lagginess wouldn't be obtrusive (or completely useless for \
regular users).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tests are comming. So far manual run.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(fee14e8)</span></li>
<li>src/swapfile/kateswapdiffcreator.cpp <span style="color: \
grey">(3b2703b)</span></li>
<li>src/swapfile/kateswapfile.h <span style="color: grey">(5e4f31d)</span></li>
<li>src/swapfile/kateswapfile.cpp <span style="color: grey">(f482af3)</span></li>
<li>src/swapfile/kateswapfilewriter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/swapfile/kateswapfilewriter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115096/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic