'Re: Review Request 115428: Tune messages about continuing search from top or bottom'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115428: Tune messages about continuing search from top or bottom
From:       "Andrey Matveyakin" <a.matveyakin () gmail ! com>
Date:       2014-02-05 22:10:36
Message-ID: 20140205221036.20382.1047 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115428/
-----------------------------------------------------------

(Updated Feb. 5, 2014, 10:10 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate.

Repository: kate

Description
-------

This patch tries to unite the functionality provided by the search widget status bar \
and the new-and-hot popup messages.

1. Make "Continuing search from top/bottom" messages disappear when user hits F3 \
                again.
Reason: when I see a "Continuing search from top" message I want to be sure that the \
topmost match is the text I see now, not another one that was 10 searched before. \
Besides, this was the status bas behavior.

2. Add "Not found" message if — surprise! — the text is not found.
Reason: honesty is the best policy.

3. Remove the status bar.
Reason: after the changes 1 and 2 it is completely duplicated by the popup messages, \
so why let it eat screen space?

P.S.
Does anyone understand, is there any idea behind the KateSearchBar::MatchNeutral \
value? There is some code for it in KateSearchBar::indicateMatch function, but it \
never triggers. This can be either a sign of a bug, or the value may just have lost \
its meaning, and can be deleted.

Diffs
-----

  part/search/katematch.h e3663c3 
  part/search/katesearchbar.h e428634 
  part/search/katesearchbar.cpp a52f25b 
  part/search/searchbarincremental.ui 097c83d 

Diff: https://git.reviewboard.kde.org/r/115428/diff/

Testing
-------

Tried to search text forward and backward in search and search/replace modes.

Thanks,

Andrey Matveyakin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115428/">https://git.reviewboard.kde.org/r/115428/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Andrey Matveyakin.</div>

<p style="color: grey;"><i>Updated Feb. 5, 2014, 10:10 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch tries to unite the functionality provided by the search \
widget status bar and the new-and-hot popup messages.

1. Make "Continuing search from top/bottom" messages disappear when user hits F3 \
                again.
Reason: when I see a "Continuing search from top" message I want to be sure that the \
topmost match is the text I see now, not another one that was 10 searched before. \
Besides, this was the status bas behavior.

2. Add "Not found" message if — surprise! — the text is not found.
Reason: honesty is the best policy.

3. Remove the status bar.
Reason: after the changes 1 and 2 it is completely duplicated by the popup messages, \
so why let it eat screen space?

P.S.
Does anyone understand, is there any idea behind the KateSearchBar::MatchNeutral \
value? There is some code for it in KateSearchBar::indicateMatch function, but it \
never triggers. This can be either a sign of a bug, or the value may just have lost \
its meaning, and can be deleted.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tried to search text forward and backward in search and search/replace \
modes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/search/katematch.h <span style="color: grey">(e3663c3)</span></li>

 <li>part/search/katesearchbar.h <span style="color: grey">(e428634)</span></li>

 <li>part/search/katesearchbar.cpp <span style="color: grey">(a52f25b)</span></li>

 <li>part/search/searchbarincremental.ui <span style="color: \
grey">(097c83d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115428/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 