[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115460: Patch for Bug 83549 - Toggling "Menubar" in Kate/KWrite
From: "Valentin Uzunov" <uzunov.val () googlemail ! com>
Date: 2014-02-05 20:32:16
Message-ID: 20140205203216.20382.71211 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 5, 2014, 10:44 a.m., Dominik Haumann wrote:
> > kwrite/kwritemain.cpp, line 319
> > <https://git.reviewboard.kde.org/r/115460/diff/2/?file=241982#file241982line319>
> >
> > Can you change the usage of spaces and braces here to:
> >
> > if (m_paShowMenuBar->isChecked()) {
> > menuBar()->show();
> > } else {
> > ...
> > }
> >
> > It's the kdelibs coding style we now strictly follow in the KF5 version of Kate. \
> > This will make it easier for us to merge your change into the frameworks branch.
I was not sure if I have to add a space between the function name and the \
parenthesis. So please let me know if I have to fix that too.
- Valentin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115460/#review49006
-----------------------------------------------------------
On Feb. 5, 2014, 8:08 p.m., Valentin Uzunov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115460/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2014, 8:08 p.m.)
>
>
> Review request for Kate.
>
>
> Bugs: 83549
> http://bugs.kde.org/show_bug.cgi?id=83549
>
>
> Repository: kate
>
>
> Description
> -------
>
> Patch for Bug 83549 - Toggling "Menubar" in Kate/KWrite.
> Added ability to toggle the menubar visibility by pressing Ctrl+M.
>
>
> Diffs
> -----
>
> kate/app/katemainwindow.h 8138dc9
> kate/app/katemainwindow.cpp 01f116b
> kwrite/kwritemain.h 203baec
> kwrite/kwritemain.cpp ee75b31
>
> Diff: https://git.reviewboard.kde.org/r/115460/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Valentin Uzunov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115460/">https://git.reviewboard.kde.org/r/115460/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 5th, 2014, 10:44 a.m. UTC, <b>Dominik \
Haumann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115460/diff/2/?file=241982#file241982line319" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwrite/kwritemain.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KWrite::urlChanged()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">319</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">KWrite</span><span class="o">::</span><span \
class="n">toggleShowMenuBar</span> <span class="p">()</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you change the usage \
of spaces and braces here to:
if (m_paShowMenuBar->isChecked()) {
menuBar()->show();
} else {
...
}
It's the kdelibs coding style we now strictly follow in the KF5 version of Kate. \
This will make it easier for us to merge your change into the frameworks \
branch.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was not \
sure if I have to add a space between the function name and the parenthesis. So \
please let me know if I have to fix that too. </pre> <br />
<p>- Valentin</p>
<br />
<p>On February 5th, 2014, 8:08 p.m. UTC, Valentin Uzunov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Valentin Uzunov.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2014, 8:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=83549">83549</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch for Bug 83549 - Toggling "Menubar" in Kate/KWrite. Added \
ability to toggle the menubar visibility by pressing Ctrl+M.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/app/katemainwindow.h <span style="color: grey">(8138dc9)</span></li>
<li>kate/app/katemainwindow.cpp <span style="color: grey">(01f116b)</span></li>
<li>kwrite/kwritemain.h <span style="color: grey">(203baec)</span></li>
<li>kwrite/kwritemain.cpp <span style="color: grey">(ee75b31)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115460/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic