'Re: Review Request 115227: made json highlighting use standard colors (color themes)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115227: made json highlighting use standard colors (color themes)
From:       "Phil Schaf" <flying-sheep () web ! de>
Date:       2014-01-28 22:49:53
Message-ID: 20140128224953.11809.88262 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Jan. 28, 2014, 8:30 p.m., Alex Turbov wrote:
> > Ship It!

done, thx. http://quickgit.kde.org/?p=kate.git&a=commit&h=d8cf07f5dd22c80452d3cba870942b9c5e127cde

- Phil

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115227/#review48496
-----------------------------------------------------------

On Jan. 28, 2014, 10:49 p.m., Phil Schaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115227/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 10:49 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> it really annoys me that people can specify their own colors. fucks up the concept of themes.
> 
> 
> Diffs
> -----
> 
>   part/syntax/data/json.xml 074486edcb17c32d4629cef107ab44d6817d6d63 
> 
> Diff: https://git.reviewboard.kde.org/r/115227/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Phil Schaf
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115227/">https://git.reviewboard.kde.org/r/115227/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On January 28th, 2014, 8:30 p.m. UTC, <b>Alex \
Turbov</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">done, thx. \
http://quickgit.kde.org/?p=kate.git&amp;a=commit&amp;h=d8cf07f5dd22c80452d3cba870942b9c5e127cde</pre>
 <br />

<p>- Phil</p>

<br />
<p>On January 28th, 2014, 10:49 p.m. UTC, Phil Schaf wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Phil Schaf.</div>

<p style="color: grey;"><i>Updated Jan. 28, 2014, 10:49 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it really annoys me that people can specify their own colors. fucks up \
the concept of themes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/syntax/data/json.xml <span style="color: \
grey">(074486edcb17c32d4629cef107ab44d6817d6d63)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115227/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 