[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115323: Build plugin: add status label and "Cancel" and "Build again" buttons
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2014-01-28 21:22:09
Message-ID: 20140128212209.791.30611 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 27, 2014, 7:33 a.m., Kåre Särs wrote:
> > I'm not sure if the cancel and build again buttons are needed. If we add a status \
> > label they do not eat to much space, but clutter the interface a bit.
> > The status idea is good :)
> > - Could you add "without problems" or "successfully" to the successful build?
> > - The wording for the failed builds could be improved. Maybe "Found %1 errors \
> > while building <b>foo</b>". The popup strings could be reused and improved.
> > It would be good to get similar info on the "Errors & Warnings" tab. There you \
> > probably also would use the build again button more but I still feel it clutters \
> > the UI
> > Idea: we could put the status on the right ofthe tab bar in the empty space... \
> > then it would be there for all the tabs and would not eat the screen estate.
> > A little bug ;)
> > If you have not gone through the "Build Target" dialog, clicking the "Build \
> > again" button will bring up the "No previous target to build." dialog.
>
> Alexander Neundorf wrote:
> > I'm not sure if the cancel and build again buttons are needed.
>
> I found myself searching for the "Cancel build" button several times, pressing Esc \
> several times without effect, so I added one. :-)
> > Could you add "without problems" or "successfully" to the successful build?
>
> Ok.
>
> > The popup strings could be reused and improved.
>
> They seemed a bit long to me, to fit in a one-line label.
>
> > It would be good to get similar info on the "Errors & Warnings" tab.
>
> I thought so too, but since the "Output" tab becomes visible automatically when a \
> build is started, I thought there it makes the most sense. And doesn't take away \
> too much space. Another idea would be to get rid of the "Errors and Warnings" tab \
> completely and highlight the errors directly in the Output tab. That's more work.
> > Idea: we could put the status on the right of the tab bar in the empty space...
>
> Where do you mean ?
>
> > If you have not gone through the "Build Target" dialog, clicking the "Build \
> > again" button will bring up the "No previous target to build." dialog.
>
> That's a feature...
> When building the default or clean targets, those are not remembered for the \
> "previous" target, since they have shortcuts anyway. But I wondered myself whether \
> this is a good idea. I'll change that.
> While at it, to me the order of the tabs feels a bit backwards.
> I.e. I would put the Targets tab first, then the output, then the errors. If you \
> agree, I can change that.
> Also, I think the Output and the Error tab contents should be cleared when \
> switching to a different target set. If you agree, I'll do that.
>
> Kåre Särs wrote:
> - I use the "stop" action for canceling the build and have assigned a shortcut for \
> it, but the discoverability could be better so a cancel button is probably a good \
> idea. It could be seen as a panic stop button ;) I think the user should be \
> "encouraged" to assign a shortcut for build/rebuild.
> - The three tabs are usually on the left and do not use the whole width of the \
> window. (How do I add a screenshot to reviewboard?)
> /Errors&Warnings\/Output\/Target Settings\____________________This space could be \
> used for status_______________________ Using a separate tab-bar and \
> widget/layout-stack would make it possible to place the status text under the \
> tab-bar when the toolview is not on the bottom
> But if we have a cancel button anyways we could just duplicate the status \
> information...
> - I have no opinion on tab order, do as you see best :)
>
> - Clearing the output and error when the target is changed seems like a good idea.
Yes, I have also a shortcut for cancelling, still I find myself sometimes looking for \
a cancel button. Yes, kind of panic stop. ;-)
Hmm, not sure I like the idea to put the status next to the tab bar.
I actually like it where I put it. :-)
Tab order and clearing the output, I'll do that in a later commit.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115323/#review48341
-----------------------------------------------------------
On Jan. 26, 2014, 9:45 p.m., Alexander Neundorf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115323/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2014, 9:45 p.m.)
>
>
> Review request for Kate and Kåre Särs.
>
>
> Repository: kate
>
>
> Description
> -------
>
> This patch adds a status label and a "Build again" and a "Cancel" button to the \
> output tab of the build plugin. The status label either shows "Building target \
> Foo...", "Building Foo cancelled" or "... completed." The "Build again" button \
> builds the previous target again, "Cancels" cancels the current build.
>
> Diffs
> -----
>
> addons/kate/katebuild-plugin/plugin_katebuild.cpp 704d684
> addons/kate/katebuild-plugin/plugin_katebuild.h 518a9cc
> addons/kate/katebuild-plugin/build.ui 782d91b
>
> Diff: https://git.reviewboard.kde.org/r/115323/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Alexander Neundorf
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115323/">https://git.reviewboard.kde.org/r/115323/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 27th, 2014, 7:33 a.m. UTC, <b>Kåre \
Särs</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not sure if the cancel and build again buttons are needed. If we \
add a status label they do not eat to much space, but clutter the interface a bit.
The status idea is good :)
- Could you add "without problems" or "successfully" to the \
successful build?
- The wording for the failed builds could be improved. Maybe "Found %1 errors \
while building <b>foo</b>". The popup strings could be reused and \
improved.
It would be good to get similar info on the "Errors & Warnings" tab. \
There you probably also would use the build again button more but I still feel it \
clutters the UI
Idea: we could put the status on the right ofthe tab bar in the empty space... then \
it would be there for all the tabs and would not eat the screen estate.
A little bug ;)
If you have not gone through the "Build Target" dialog, clicking the \
"Build again" button will bring up the "No previous target to \
build." dialog.</pre> </blockquote>
<p>On January 27th, 2014, 8:46 p.m. UTC, <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I'm not sure if \
the cancel and build again buttons are needed.
I found myself searching for the "Cancel build" button several times, \
pressing Esc several times without effect, so I added one. :-)
> Could you add "without problems" or "successfully" to the \
successful build?
Ok.
> The popup strings could be reused and improved.
They seemed a bit long to me, to fit in a one-line label.
> It would be good to get similar info on the "Errors & Warnings" \
tab.
I thought so too, but since the "Output" tab becomes visible automatically \
when a build is started, I thought there it makes the most sense. And doesn't \
take away too much space. Another idea would be to get rid of the "Errors and \
Warnings" tab completely and highlight the errors directly in the Output tab. \
That's more work.
> Idea: we could put the status on the right of the tab bar in the empty space...
Where do you mean ?
> If you have not gone through the "Build Target" dialog, clicking the \
"Build again" button will bring up the "No previous > target to \
build." dialog.
That's a feature...
When building the default or clean targets, those are not remembered for the \
"previous" target, since they have shortcuts anyway. But I wondered myself \
whether this is a good idea. I'll change that.
While at it, to me the order of the tabs feels a bit backwards.
I.e. I would put the Targets tab first, then the output, then the errors. If you \
agree, I can change that.
Also, I think the Output and the Error tab contents should be cleared when switching \
to a different target set. If you agree, I'll do that. </pre>
</blockquote>
<p>On January 28th, 2014, 8:14 a.m. UTC, <b>Kåre Särs</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- I use the \
"stop" action for canceling the build and have assigned a shortcut for it, \
but the discoverability could be better so a cancel button is probably a good idea. \
It could be seen as a panic stop button ;) I think the user should be \
"encouraged" to assign a shortcut for build/rebuild.
- The three tabs are usually on the left and do not use the whole width of the \
window. (How do I add a screenshot to reviewboard?)
/Errors&Warnings\/Output\/Target Settings\____________________This space could be \
used for status_______________________ Using a separate tab-bar and \
widget/layout-stack would make it possible to place the status text under the tab-bar \
when the toolview is not on the bottom
But if we have a cancel button anyways we could just duplicate the status \
information...
- I have no opinion on tab order, do as you see best :)
- Clearing the output and error when the target is changed seems like a good \
idea.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I have also a \
shortcut for cancelling, still I find myself sometimes looking for a cancel button. \
Yes, kind of panic stop. ;-)
Hmm, not sure I like the idea to put the status next to the tab bar.
I actually like it where I put it. :-)
Tab order and clearing the output, I'll do that in a later commit.
</pre>
<br />
<p>- Alexander</p>
<br />
<p>On January 26th, 2014, 9:45 p.m. UTC, Alexander Neundorf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Kåre Särs.</div>
<div>By Alexander Neundorf.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2014, 9:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a status label and a "Build again" and a \
"Cancel" button to the output tab of the build plugin. The status label \
either shows "Building target Foo...", "Building Foo cancelled" \
or "... completed." The "Build again" button builds the previous \
target again, "Cancels" cancels the current build. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manually tested.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/kate/katebuild-plugin/plugin_katebuild.cpp <span style="color: \
grey">(704d684)</span></li>
<li>addons/kate/katebuild-plugin/plugin_katebuild.h <span style="color: \
grey">(518a9cc)</span></li>
<li>addons/kate/katebuild-plugin/build.ui <span style="color: \
grey">(782d91b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115323/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic