[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Fwd: [ktexteditor] src/view: we need a second fix for the scrollbar problem, else we crash, as we ha
From:       Christoph Cullmann <cullmann () absint ! com>
Date:       2014-01-22 22:06:46
Message-ID: 1854368812.192544.1390428406486.JavaMail.zimbra () absint ! com
[Download RAW message or body]

Hi,

could you backport that change? Else we have a crash now :)

Greetings
Christoph

----- Weitergeleitete Mail -----
Von: "Christoph Cullmann" <cullmann@kde.org>
An: kde-commits@kde.org
Gesendet: Mittwoch, 22. Januar 2014 23:06:06
Betreff: [ktexteditor] src/view: we need a second fix for the scrollbar problem, else \
we crash, as we have no lines

Git commit f321e43489adbac5b7b7279ac395c4998d56054f by Christoph Cullmann.
Committed on 22/01/2014 at 22:06.
Pushed by cullmann into branch 'master'.

we need a second fix for the scrollbar problem, else we crash, as we have no lines

M  +2    -2    src/view/kateviewinternal.cpp

http://commits.kde.org/ktexteditor/f321e43489adbac5b7b7279ac395c4998d56054f

diff --git a/src/view/kateviewinternal.cpp b/src/view/kateviewinternal.cpp
index 3e06701..9eee292 100644
--- a/src/view/kateviewinternal.cpp
+++ b/src/view/kateviewinternal.cpp
@@ -299,8 +299,8 @@ KTextEditor::Cursor KateViewInternal::endPos() const
         return KTextEditor::Cursor(thisLine.virtualLine(), thisLine.wrap() ? \
thisLine.endCol() - 1 : thisLine.endCol());  }
 
-    qCDebug(LOG_PART) << "WARNING: could not find a lineRange at all";
-    return KTextEditor::Cursor(-1, -1);
+    // can happen, if view is still invisible
+    return KTextEditor::Cursor();
 }
 
 int KateViewInternal::endLine() const


-- 
----------------------------- Dr.-Ing. Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH      Email: cullmann@AbsInt.com
Science Park 1                         Tel:   +49-681-38360-22
66123 Saarbrücken                      Fax:   +49-681-38360-20
GERMANY                                WWW:   http://www.AbsInt.com
--------------------------------------------------------------------
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]