'Re: Review Request 115205: vimode: added some motions and text objects that were missing in the visu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115205: vimode: added some motions and text objects that were missing in the visu
From:       "Commit Hook" <null () kde ! org>
Date:       2014-01-22 10:41:58
Message-ID: 20140122104158.17756.58767 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115205/#review47993
-----------------------------------------------------------

This review has been submitted with commit a9120ed21c51382a38a0af512075232bd7cfd8a1 \
by Miquel SabatĂŠ to branch master.

- Commit Hook

On Jan. 22, 2014, 10:32 a.m., Miquel SabatĂŠ SolĂ  wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115205/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 10:32 a.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> With this patch I'm adding motions and text objects available in normal mode and \
> that were missing in visual mode. This is, indeed, hiding a bit the problem of \
> duplication of code that we have between normal and visual mode regarding \
> initializing the commands and motions available. I've tried a couple of things like \
> removing lines like:   qDeleteAll(m_motions); m_motions.clear(); but then some \
> tests fail. So, I thought to just submit this patch to fix these motions and text \
> objects right now, but with the note that we should provide a better fix around the \
> whole problem :) 
> 
> Diffs
> -----
> 
> part/vimode/katevivisualmode.cpp d912860 
> 
> Diff: https://git.reviewboard.kde.org/r/115205/diff/
> 
> 
> Testing
> -------
> 
> Manual testing. Tests are passing.
> 
> 
> Thanks,
> 
> Miquel SabatĂŠ SolĂ 
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115205/">https://git.reviewboard.kde.org/r/115205/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a9120ed21c51382a38a0af512075232bd7cfd8a1 by Miquel SabatĂŠ to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On January 22nd, 2014, 10:32 a.m. UTC, Miquel SabatĂŠ SolĂ  wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated Jan. 22, 2014, 10:32 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch I&#39;m adding motions and text objects available in \
normal mode and that were missing in visual mode. This is, indeed, hiding a bit the \
problem of duplication of code that we have between normal and visual mode regarding \
initializing the commands and motions available. I&#39;ve tried a couple of things \
like removing lines like:   qDeleteAll(m_motions); m_motions.clear(); but then some \
tests fail. So, I thought to just submit this patch to fix these motions and text \
objects right now, but with the note that we should provide a better fix around the \
whole problem :) </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual testing. Tests are passing.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/vimode/katevivisualmode.cpp <span style="color: grey">(d912860)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115205/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 