[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115155: vimode: fixed two crashes related to the undo/redo operations
From: "Commit Hook" <null () kde ! org>
Date: 2014-01-20 17:42:44
Message-ID: 20140120174244.18280.59467 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115155/#review47834
-----------------------------------------------------------
This review has been submitted with commit a71c932bf34a938dc271dd13169e2adce4f3b210 \
by Miquel Sabaté to branch master.
- Commit Hook
On Jan. 20, 2014, 5:41 p.m., Miquel Sabaté Solà wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115155/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2014, 5:41 p.m.)
>
>
> Review request for Kate.
>
>
> Bugs: 328277 and 330025
> http://bugs.kde.org/show_bug.cgi?id=328277
> http://bugs.kde.org/show_bug.cgi?id=330025
>
>
> Repository: kate
>
>
> Description
> -------
>
> With this patch we make sure that we actually have stuff to redo/undo before doing \
> it. With this patch we'll always return the proper value.
>
> Diffs
> -----
>
> part/vimode/katevinormalmode.cpp 5bb20f4
> tests/vimode_test.cpp 335195c
>
> Diff: https://git.reviewboard.kde.org/r/115155/diff/
>
>
> Testing
> -------
>
> Manual testing
>
>
> Thanks,
>
> Miquel SabatĂ© SolĂ
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115155/">https://git.reviewboard.kde.org/r/115155/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a71c932bf34a938dc271dd13169e2adce4f3b210 by Miquel Sabaté to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On January 20th, 2014, 5:41 p.m. UTC, Miquel Sabaté Solà wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Miquel Sabaté Solà .</div>
<p style="color: grey;"><i>Updated Jan. 20, 2014, 5:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=328277">328277</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=330025">330025</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch we make sure that we actually have stuff to redo/undo \
before doing it. With this patch we'll always return the proper value.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual testing</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/vimode/katevinormalmode.cpp <span style="color: grey">(5bb20f4)</span></li>
<li>tests/vimode_test.cpp <span style="color: grey">(335195c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115155/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic