'Re: Review Request 114395: add partial RST support to cmake.xml'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114395: add partial RST support to cmake.xml
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2014-01-17 18:07:58
Message-ID: 20140117180758.13143.77423 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114395/
-----------------------------------------------------------

(Updated Jan. 17, 2014, 6:07 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate, Alexander Neundorf, Stephen Kelly, and Alex Turbov.

Repository: kate

Description
-------

Add support for CMake 3.0 "long bracket" syntax (for string quoting and comments), \
and for use of RST in RST bracket comments. (RST in normal comments can't be \
trivially highlighted, as it relies on implicit removal of the leading comment \
character, and thus is not supported.)

Diffs
-----

  .gitlog PRE-CREATION 
  part/syntax/data/cmake.xml ccf3bb630d1451b3facb905f582a16a615b4caaa 

Diff: https://git.reviewboard.kde.org/r/114395/diff/

Testing
-------

Highlighting works as expected when adding new syntax constructs to a CMake file.

Thanks,

Matthew Woehlke

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114395/">https://git.reviewboard.kde.org/r/114395/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate, Alexander Neundorf, Stephen Kelly, and Alex \
Turbov.</div> <div>By Matthew Woehlke.</div>

<p style="color: grey;"><i>Updated Jan. 17, 2014, 6:07 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add support for CMake 3.0 &quot;long bracket&quot; syntax (for string \
quoting and comments), and for use of RST in RST bracket comments. (RST in normal \
comments can&#39;t be trivially highlighted, as it relies on implicit removal of the \
leading comment character, and thus is not supported.)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Highlighting works as expected when adding new syntax constructs to a \
CMake file.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>.gitlog <span style="color: grey">(PRE-CREATION)</span></li>

 <li>part/syntax/data/cmake.xml <span style="color: \
grey">(ccf3bb630d1451b3facb905f582a16a615b4caaa)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114395/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 